Skip to content

refactor(web): complete public feature boundaries - #365

Open
luannn010 wants to merge 19 commits into
refactor/thread-public-api-part-onefrom
refactor/thread-public-api-part-two
Open

luannn010 wants to merge 19 commits into
refactor/thread-public-api-part-onefrom
refactor/thread-public-api-part-two

Conversation

@luannn010

@luannn010 luannn010 commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Closes #334

Risk: initialization or lint regression. Rollback: revert this commit.

Parity rows

none

Frames built

Frames built: none

Testing

  • Windows: 549 boundary cases, 199 consumer tests, five App cases; type/lint/build passed.
  • Future-feature/fixed-template tests failed before, passed afterward.
  • AST: nine facades, 55 outside edges public; zero violations/computed paths.
  • Independent source review: no findings. Three CSS assets byte-identical.
  • Not run locally: full suite, browser, Rust, packaged app, macOS or real providers.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Codex desktop; Codex CLI 0.160.0; native agents, PowerShell, Python, Git, GitHub CLI, Node/npm, ESLint, TypeScript, Vitest, Vite and PostCSS.
  • Models: gpt-6.1-sol (design, boundary fixtures and failing-before checks, integration, local verification/CSS comparison and delivery; separate independent source/fixture reviewer); gpt-6.1-terra (14-file remaining thread consumer, facade, lint and documentation implementation); gpt-6-luna (coordinator's public issue/comment/linked-PR intake metadata, current-main compatibility inventory and mechanical thread importer/binding inventory; no design, implementation or runtime verification).
  • Effort: medium for all listed roles.
  • Human role: selected issue and authorized the small pieces, bounded branch sequence and ready stacked PR publication; retains merge authority.
  • Sources: Luan Nguyen's PR #285, commit 45a7297da5056f6e75db30ab7cc3b1bd8458677b, for the public-entry-point and lint approach. Its thread facade included Composer, ThreadScope, Transcript, traits, ModelPickerTrigger and detail-menu bindings; this interface follows current consumers and owners. Same-repository reference; no outside source/assets copied.

Checklist

  • Works on Windows and macOS
  • web/src/generated with any contract change; docs/architecture.md with any rule change (neither changed)
  • No copied outside source, secrets, credentials or personal data; no AI attribution in commits, title or branch

@luannn010
luannn010 requested a review from kinqsradio as a code owner November 8, 2026 10:00
@github-actions github-actions Bot added the area: web web: React UI label Nov 8, 2026
@luannn010

Copy link
Copy Markdown
Collaborator Author

@kinqsradio ready for review at 232d9ffa: all current-head checks are green. Thread-b boundary piece for #334; stacked on the preceding piece; merge in stack order. Focused consumer tests, type/lint/build and independent source/CSS review passed. Hosted Web and all eight E2E commands executed successfully; native/platform lanes were path-gated. See the PR for local qualification limits.

Completed #334 stack: #350 → #355 → #356 → #358 → #359 → #360 → #361 → #362 → #364 → #365. Merge bottom-up, confirming the next PR targets main after its predecessor lands.

@kinqsradio
kinqsradio force-pushed the refactor/thread-public-api-part-one branch from 4039ecb to 0de8989 Compare November 10, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant