Skip to content

refactor(web): enforce the settings feature boundary - #356

Open
luannn010 wants to merge 1 commit into
refactor/platform-public-apifrom
refactor/settings-public-api
Open

luannn010 wants to merge 1 commit into
refactor/platform-public-apifrom
refactor/settings-public-api

Conversation

@luannn010

@luannn010 luannn010 commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Related #334

Risk: import initialization or lint regression. Rollback: revert this commit.

Parity rows

none

Frames built

Frames built: none

Testing

  • Current-main integration on Windows: 149 focused boundary/search/task tests and two App startup/title-bar checks passed; full type/lint and production build passed.
  • Independent actual-diff review: no findings; all three production CSS assets byte-identical to the updated predecessor.
  • Not run locally: full unit suite, Rust, browser, packaged app, macOS or real providers.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Codex desktop; Codex CLI 0.160.0; native agents, PowerShell, Python, Git, GitHub CLI, Node/npm, ESLint, TypeScript, Vitest and Vite.
  • Models: gpt-6.1-sol (design, integration, local verification and delivery; separate independent source reviewer); gpt-6.1-terra (six-file settings implementation and fixtures); gpt-6-luna (coordinator's bounded public issue/comment/linked-PR intake metadata and current-main export/import compatibility inventory; no design, implementation or runtime verification).
  • Effort: medium for all listed roles.
  • Human role: selected issue and authorized starting the small pieces now, the bounded branch sequence and ready stacked PR publication; retains merge authority.
  • Sources: Luan Nguyen's PR #285, commit 45a7297da5056f6e75db30ab7cc3b1bd8458677b, for the narrow public-entry-point and lint approach. Its settings facade exposed HistoryImport, which has no current outside consumer; this facade follows current consumers without restoring that unused export. Same-repository reference; no outside source/assets copied.

Checklist

  • Works on Windows and macOS
  • web/src/generated with any contract change; docs/architecture.md with any rule change (neither changed)
  • No copied outside source, secrets, credentials or personal data; no AI attribution in commits, title or branch

@luannn010
luannn010 requested a review from kinqsradio as a code owner November 8, 2026 07:56
@github-actions github-actions Bot added the area: web web: React UI label Nov 8, 2026
@luannn010

luannn010 commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator Author

@kinqsradio ready for review at e7bfbfd2: all current-head checks are green. Settings boundary piece for #334; stacked on the preceding piece; merge in stack order. Focused consumer tests, type/lint/build and independent source/CSS review passed. Hosted Web and all eight E2E commands executed successfully; native/platform lanes were path-gated. See the PR for local qualification limits.

Expose SettingsPage and ScheduledTasksPage through features/settings/index.ts and route the shell consumers through it.
@kinqsradio
kinqsradio force-pushed the refactor/platform-public-api branch from 0a9ba0e to dcb983f Compare November 10, 2026 06:01
@kinqsradio
kinqsradio force-pushed the refactor/settings-public-api branch from e7bfbfd to fc754ad Compare November 10, 2026 06:01

@kinqsradio kinqsradio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after rebuilding this layer on current main: it now uses features/settings/index.ts and the existing arch-check boundary instead of a parallel public.ts/ESLint layer. Head fc754ad; local npm run check, npm run build, cargo fmt and the Rust workspace suite passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants