Repository navigation
Conversation
2 of 4 tasks
Collaborator
Author
|
@kinqsradio ready for review at |
2 of 4 tasks
Expose SettingsPage and ScheduledTasksPage through features/settings/index.ts and route the shell consumers through it.
kinqsradio
force-pushed
the
refactor/platform-public-api
branch
from
November 10, 2026 06:01
0a9ba0e to
dcb983f
Compare
kinqsradio
force-pushed
the
refactor/settings-public-api
branch
from
November 10, 2026 06:01
e7bfbfd to
fc754ad
Compare
kinqsradio
approved these changes
Nov 10, 2026
kinqsradio
left a comment
Member
There was a problem hiding this comment.
Re-reviewed after rebuilding this layer on current main: it now uses features/settings/index.ts and the existing arch-check boundary instead of a parallel public.ts/ESLint layer. Head fc754ad; local npm run check, npm run build, cargo fmt and the Rust workspace suite passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SettingsPageandScheduledTasksPagethrough settings/public.ts; migrate Shell.Related #334
Risk: import initialization or lint regression. Rollback: revert this commit.
Parity rows
none
Frames built
Frames built: none
Testing
Co-authors
none
AI usage
45a7297da5056f6e75db30ab7cc3b1bd8458677b, for the narrow public-entry-point and lint approach. Its settings facade exposed HistoryImport, which has no current outside consumer; this facade follows current consumers without restoring that unused export. Same-repository reference; no outside source/assets copied.Checklist
web/src/generatedwith any contract change;docs/architecture.mdwith any rule change (neither changed)