Add support for Azure Key Vault and updated deps #204
Conversation
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
markxnelson
changed the title
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
|
|
||
| The exporter will read the database username and password from secrets stored in Azure Key Vault if you set these environment variables: | ||
|
|
||
| - `AZ_VAULT_ID` should be set to the ID of the Azure Key Vault that you wish to use |
There was a problem hiding this comment.
How does Azure support the equivalent of OCI workload identity?
There was a problem hiding this comment.
see authentication, right below this, it has links to that info
| password = ocivault.GetVaultSecret(ociVaultID, os.Getenv("OCI_VAULT_SECRET_NAME")) | ||
| } | ||
|
|
||
| azVaultID, useAzVault := os.LookupEnv("AZ_VAULT_ID") |
There was a problem hiding this comment.
Typically this would be implemented using a provider pattern, e.g., a database authentication provider that OCI, Azure, and any other authentication providers would implement. Each provider implements the same interface, and there is a enum parameter to select between the chosen provider.
There was a problem hiding this comment.
azure does not have different apis like oci does, it just automagically works it out :)
There was a problem hiding this comment.
oh, scratch that, i see what you mean
There was a problem hiding this comment.
i can create an issue to refactor that later
There was a problem hiding this comment.
Do we need to get this done now rather than do it right the first go-round?
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Allow the exporter to obtain the database username and password from Azure Key Vault.
Update deps.