review commetns

Signed-off-by: Mark Nelson <[email protected]>

Author: markxnelson

Diff for: azvault/azvault.go

@@ -6,6 +6,7 @@ package azvault
 import (
 	"context"
 	"fmt"
+	"os"
 	"strings"
 
 	"github.com/prometheus/common/promslog"
@@ -24,17 +25,23 @@ func GetVaultSecret(vaultId string, secretName string) string {
 	cred, err := azidentity.NewDefaultAzureCredential(nil)
 	if err != nil {
 		logger.Error("Failed to obtain an Azure Credential", "err", err)
+		os.Exit(1)
 	}
 
 	// establish a connection to the key vault client
 	client, err := azsecrets.NewClient(vaultURI, cred, nil)
+	if err != nil {
+		logger.Error("Failed to create Azure Secrets Client", "err", err)
+		os.Exit(1)
+	}
 
 	// get the secret - empty string version means "latest"
 	version := ""
 	secret := ""
 	resp, err := client.GetSecret(context.TODO(), secretName, version, nil)
 	if err != nil {
 		logger.Error("Failed to get secret from vault", "err", err)
+		os.Exit(1)
 	} else {
 		secret = *resp.Value
 	}