-
-
Notifications
You must be signed in to change notification settings - Fork 301
1、增加用户密码随时产生8位,由大小写字母、数字、特殊字符。 2、增加添加用户时新用户名和密码通过邮箱发送给用户。 #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kiven0201
wants to merge
4
commits into
opsre:main
Choose a base branch
from
kiven0201:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,23 @@ | ||||||
package tools | ||||||
|
||||||
import ( | ||||||
"crypto/rand" | ||||||
"math/big" | ||||||
) | ||||||
|
||||||
const ( | ||||||
passwordLength = 8 | ||||||
letters = "abcdefghijklmnopqrstu@vwxyzABCDEFGHIJKL#MNOP*QRSTUVWXYZ0123456789" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 随机密码生成函数中的字符集缺少一些常用的特殊字符,如$、%、&、!等,这可能会降低密码的强度。
Suggested change
|
||||||
lettersLength = len(letters) | ||||||
) | ||||||
|
||||||
func GenerateRandomPassword() string { | ||||||
password := make([]byte, passwordLength) | ||||||
|
||||||
for i := range password { | ||||||
index, _ := rand.Int(rand.Reader, big.NewInt(int64(lettersLength))) | ||||||
password[i] = letters[index.Int64()] | ||||||
} | ||||||
|
||||||
return string(password) | ||||||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package tools | ||
|
||
import "time" | ||
|
||
func ConvertToTimestamp(t time.Time) int64 { | ||
timestamp := t.Unix() | ||
return timestamp | ||
} | ||
|
||
func CalculateDaysBetweenTimestamps(timestamp1, timestamp2 int64) int { | ||
t1 := time.Unix(timestamp1, 0) | ||
t2 := time.Unix(timestamp2, 0) | ||
|
||
duration := t2.Sub(t1) | ||
days := int(duration.Hours() / 24) | ||
return days | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -143,7 +143,9 @@ func (x UserService) NewPwd(username string) (string, error) { | |||||||||
if username == "admin" { | ||||||||||
udn = config.Conf.Ldap.AdminDN | ||||||||||
} | ||||||||||
modifyPass := ldap.NewPasswordModifyRequest(udn, "", "") | ||||||||||
//默认产生8位随机密码,不符合公司规范,故生成16位随机密码 | ||||||||||
newPasswd := tools.GenerateRandomPassword() | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 在NewPwd函数中,注释说明生成16位随机密码,但实际代码中调用GenerateRandomPassword()函数并未指定长度(默认8位),与注释不符。建议添加一个可指定长度的密码生成函数。
Suggested change
|
||||||||||
modifyPass := ldap.NewPasswordModifyRequest(udn, "", newPasswd) | ||||||||||
|
||||||||||
// 获取 LDAP 连接 | ||||||||||
conn, err := common.GetLDAPConn() | ||||||||||
|
@@ -156,6 +158,8 @@ func (x UserService) NewPwd(username string) (string, error) { | |||||||||
if err != nil { | ||||||||||
return "", fmt.Errorf("password modify failed for %s, err: %v", username, err) | ||||||||||
} | ||||||||||
|
||||||||||
newpass.GeneratedPassword = newPasswd | ||||||||||
return newpass.GeneratedPassword, nil | ||||||||||
} | ||||||||||
func (x UserService) ListUserDN() (users []*model.User, err error) { | ||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在定时任务错误处理中,日志输出的错误信息"eteststset"看起来像是测试代码残留,应该改为更有意义的错误描述。