1、增加用户密码随时产生8位,由大小写字母、数字、特殊字符。 2、增加添加用户时新用户名和密码通过邮箱发送给用户。 #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请问这个pr是否还会有新的功能？ |
|
这个功能怎么使用？ |
未合并，无法用，太过久远，就不合并了 |
|
后面会做上么？不然每次建立用户都需要去修改密码 也是麻烦，自动发一个随机密码去邮箱我觉得是一个不错的功能 |
|
@MonkeyCode-AI review |
| }) | ||
| if err != nil { | ||
| common.Log.Errorf("eteststset: %v", err) | ||
| } |
There was a problem hiding this comment.
在定时任务错误处理中，日志输出的错误信息"eteststset"看起来像是测试代码残留，应该改为更有意义的错误描述。
Suggested change
| } | |
| common.Log.Errorf("Failed to add user expiration check cron job: %v", err) |
|
|
||
| const ( | ||
| passwordLength = 8 | ||
| letters = "abcdefghijklmnopqrstu@vwxyzABCDEFGHIJKL#MNOP*QRSTUVWXYZ0123456789" |
There was a problem hiding this comment.
随机密码生成函数中的字符集缺少一些常用的特殊字符，如$、%、&、!等，这可能会降低密码的强度。
Suggested change
| letters = "abcdefghijklmnopqrstu@vwxyzABCDEFGHIJKL#MNOP*QRSTUVWXYZ0123456789" | |
| letters = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789@#$%&*!" |
| } | ||
| modifyPass := ldap.NewPasswordModifyRequest(udn, "", "") | ||
| //默认产生8位随机密码，不符合公司规范，故生成16位随机密码 | ||
| newPasswd := tools.GenerateRandomPassword() |
There was a problem hiding this comment.
在NewPwd函数中，注释说明生成16位随机密码，但实际代码中调用GenerateRandomPassword()函数并未指定长度（默认8位），与注释不符。建议添加一个可指定长度的密码生成函数。
Suggested change
| newPasswd := tools.GenerateRandomPassword() | |
| // 默认产生8位随机密码，不符合公司规范，故生成16位随机密码 | |
| // newPasswd := tools.GenerateRandomPassword() | |
| newPasswd := tools.GenerateRandomPasswordWithLength(16) |
|
⏳ MonkeyCode-AI 正在分析，请稍等片刻... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在提出此拉取请求时，我确认了以下几点（请复选框）：
填写PR内容：