-
Notifications
You must be signed in to change notification settings - Fork 4.8k
OCPBUGS-61376: Isolate HPA tests #30411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-61376: Isolate HPA tests #30411
Conversation
|
@maxcao13: This pull request references Jira Issue OCPBUGS-61376, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/hold |
We need to isolate HPA parallel tests because of resource contention with other parallelized tests. Signed-off-by: Max Cao <[email protected]>
9a23f12 to
3007cfa
Compare
|
The tests require openshift/kubernetes#2492 to actually show that the isolation solves the OCPBUGS problem since the HPA tests are currently disabled. But my multi-pr test command in that PR is not playing well right now: openshift/kubernetes#2492 (comment) |
|
lgtm - but I want to verify via the job results before tagging |
|
/lgtm Won't see those test as they are skipped currently |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxcao13, neisw, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/verified bypass |
|
@neisw: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 3007cfa
New tests seen in this PR at sha: 3007cfa
|
|
/hold Revision 3007cfa was retested 3 times: holding |
|
@maxcao13: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Tests are unrelated to the change. Am I supposed to rebase on main because we merged 1.34 bump yesterday or will these flakes eventually resolve? |
|
/retest-required |
|
/unhold |
20578e7
into
openshift:main
|
@maxcao13: Jira Issue OCPBUGS-61376: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-61376 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
We need to isolate HPA parallel tests because of resource contention with other parallelized tests.