Skip to content

(olmv1) Refractor tests for better readability #29840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented May 22, 2025

Also get rid of "exponential backoff with jitter" usage in verifyAPIEndpoints and use an increased timeout of 2min for "pollUntilContextDeadline" instead.

@openshift-ci openshift-ci bot requested review from everettraven and tmshort May 22, 2025 14:19
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anik120
Once this PR has been reviewed and has the lgtm label, please assign lalatendumohanty for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor

tmshort commented May 22, 2025

Would it be possible to move these tests to their own file? I've been trying to organize things by file in this directory.

Also get rid of "exponential backoff with jitter" usage in
`verifyAPIEndpoints` and use an increased timeout of 2min
for "pollUntilContextDeadline" instead.
@anik120 anik120 force-pushed the olmv1-tests-refractor-again branch from 3b39789 to 905d435 Compare May 22, 2025 14:51
@anik120
Copy link
Contributor Author

anik120 commented May 22, 2025

@tmshort that's actually a great idea. Just pushed a change with a new file "olmv1-catalogd.go".

Note for reviewers who haven't seen the actual change, please see 3b39789 for a better view of the actual changes, aside from the new file addition.

Copy link
Contributor

openshift-ci bot commented May 22, 2025

@anik120: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-fips-serial-1of2 905d435 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 905d435 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 905d435 link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-aws-disruptive 905d435 link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-ovn-etcd-scaling 905d435 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/okd-e2e-gcp 905d435 link false /test okd-e2e-gcp
ci/prow/e2e-vsphere-ovn-etcd-scaling 905d435 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 905d435 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn-upgrade 905d435 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-azure-ovn-etcd-scaling 905d435 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-2of2 905d435 link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-gcp-disruptive 905d435 link false /test e2e-gcp-disruptive
ci/prow/e2e-openstack-serial 905d435 link false /test e2e-openstack-serial
ci/prow/e2e-aws-ovn 905d435 link false /test e2e-aws-ovn
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 905d435 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-openstack-ovn 905d435 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-etcd-scaling 905d435 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-serial-2of2 905d435 link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-aws-ovn-serial-publicnet-2of2 905d435 link false /test e2e-aws-ovn-serial-publicnet-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants