OCPBUGS-35855: Add dry-run server test for imagestreamtag

[ardaguclu]

This PR adds a simple test to ensure that dry-run option is taken account by image api server.

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-35855, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR adds a simple test to ensure that dry-run option is taken account by image api server.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ardaguclu]

This test should fail without openshift/openshift-apiserver#511
/hold

[ardaguclu]

Without the patch in openshift-apiserver, https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29834/pull-ci-openshift-origin-main-e2e-aws-ovn-image-registry/1925162064351858688 failed as expected.

[flavianmissi]

/lgtm

[ardaguclu]

/retest

[ardaguclu]

/retest

[ardaguclu]

/hold cancel

[p0lyn0mial]

/lgtm

[dgoodwin]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, dgoodwin, flavianmissi, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/extended/images/OWNERS [dgoodwin,flavianmissi]
• test/extended/util/annotate/generated/OWNERS [dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ardaguclu]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD 2bc880f in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD 2bc880f in total

[ardaguclu]

/retest-required

[ardaguclu]

/retest-required

[ardaguclu]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD 2bc880f in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e47a79b and 1 for PR HEAD 2bc880f in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6c48344 and 0 for PR HEAD 2bc880f in total

[openshift-ci-robot]

/hold

Revision 2bc880f was retested 3 times: holding

[openshift-ci]

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-disruptive	2bc880f	link	false	/test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-serial-publicnet-1of2	2bc880f	link	false	/test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-aws-ovn-etcd-scaling	2bc880f	link	false	/test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling	2bc880f	link	false	/test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2	2bc880f	link	false	/test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-azure-ovn-upgrade	2bc880f	link	false	/test e2e-azure-ovn-upgrade
ci/prow/okd-e2e-gcp	2bc880f	link	false	/test okd-e2e-gcp
ci/prow/e2e-gcp-ovn-rt-upgrade	2bc880f	link	false	/test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	2bc880f	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-disruptive	2bc880f	link	false	/test e2e-gcp-disruptive
ci/prow/e2e-gcp-fips-serial-2of2	2bc880f	link	false	/test e2e-gcp-fips-serial-2of2
ci/prow/e2e-gcp-ovn-etcd-scaling	2bc880f	link	false	/test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2	2bc880f	link	false	/test e2e-gcp-fips-serial-1of2
ci/prow/e2e-openstack-serial	2bc880f	link	false	/test e2e-openstack-serial
ci/prow/e2e-aws-ovn-single-node-upgrade	2bc880f	link	false	/test e2e-aws-ovn-single-node-upgrade
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback	2bc880f	link	false	/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-vsphere-ovn-etcd-scaling	2bc880f	link	false	/test e2e-vsphere-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-trt]

Job Failure Risk Analysis for sha: 2bc880f

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive	Medium [sig-node] static pods should start after being created Potential external regression detected for High Risk Test analysis --- [bz-Etcd] clusteroperator/etcd should not change condition/Available Potential external regression detected for High Risk Test analysis --- [sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling	High [sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times This test has passed 100.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week. --- [bz-etcd][invariant] alert/etcdMembersDown should not be at or above info This test has passed 99.87% of 4658 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade	IncompleteTests Tests for this run (2124) are below the historical average (2984): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-disruptive	High [sig-node] static pods should start after being created This test has passed 99.18% of 4730 runs on release 4.20 [Overall] in the last week. --- [sig-node] node-lifecycle detects unexpected not ready node This test has passed 99.70% of 4730 runs on release 4.20 [Overall] in the last week. Open Bugs node-lifecycle detects unexpected not ready node failing on azure serial and upgrade jobs --- [sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times This test has passed 100.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:hidden Network:cilium NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling	Low [bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling	Medium [sig-network] pods should successfully create sandboxes by adding pod to network This test has passed 93.74% of 4730 runs on release 4.20 [Overall] in the last week.

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 2bc880f

Job Name	New Test Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6	High - "[sig-imageregistry] Image --dry-run should not delete resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi	High - "[sig-imageregistry] Image --dry-run should not delete resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: 2bc880f

• "[sig-imageregistry] Image --dry-run should not delete resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 39, Pass: 39, Fail: 0, Flake: 0]

[ardaguclu]

/hold cancel
/retest-required

[openshift-ci-robot]

@ardaguclu: Jira Issue OCPBUGS-35855: All pull requests linked via external trackers have merged:

• openshift/openshift-apiserver#511
• openshift/origin#29834

Jira Issue OCPBUGS-35855 has been moved to the MODIFIED state.

In response to this:

This PR adds a simple test to ensure that dry-run option is taken account by image api server.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202506020843.p0.g37bb057.assembly.stream.el9.
All builds following this will include this PR.

[wangke19]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@wangke19: #29834 failed to apply on top of branch "release-4.19":

Applying: Add dry-run server test for imagestreamtag
Using index info to reconstruct a base tree...
M	test/extended/util/annotate/generated/zz_generated.annotations.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/annotate/generated/zz_generated.annotations.go
CONFLICT (content): Merge conflict in test/extended/util/annotate/generated/zz_generated.annotations.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add dry-run server test for imagestreamtag

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.