Skip to content

OCPBUGS-56128: openstack-cinder: Set --with-topology flag for node driver also #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,18 @@ spec:
- --provide-node-service=true
- --endpoint=$(CSI_ENDPOINT)
- --cloud-config=$(CLOUD_CONFIG)
- --with-topology=$(ENABLE_TOPOLOGY)
- --v=${LOG_LEVEL}
env:
- name: CSI_ENDPOINT
value: unix://csi/csi.sock
- name: CLOUD_CONFIG
value: /etc/kubernetes/config/cloud.conf
- name: ENABLE_TOPOLOGY
valueFrom:
configMapKeyRef:
key: enable_topology
name: cloud-conf
image: ${DRIVER_IMAGE}
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,18 @@ spec:
- --provide-node-service=true
- --endpoint=$(CSI_ENDPOINT)
- --cloud-config=$(CLOUD_CONFIG)
- --with-topology=$(ENABLE_TOPOLOGY)
- --v=${LOG_LEVEL}
env:
- name: CSI_ENDPOINT
value: unix://csi/csi.sock
- name: CLOUD_CONFIG
value: /etc/kubernetes/config/cloud.conf
- name: ENABLE_TOPOLOGY
valueFrom:
configMapKeyRef:
key: enable_topology
name: cloud-conf
image: ${DRIVER_IMAGE}
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down
6 changes: 6 additions & 0 deletions assets/overlays/openstack-cinder/patches/node_add_driver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,18 @@ spec:
- "--provide-node-service=true"
- "--endpoint=$(CSI_ENDPOINT)"
- "--cloud-config=$(CLOUD_CONFIG)"
- "--with-topology=$(ENABLE_TOPOLOGY)"
- "--v=${LOG_LEVEL}"
env:
- name: CSI_ENDPOINT
value: unix://csi/csi.sock
- name: CLOUD_CONFIG
value: /etc/kubernetes/config/cloud.conf
- name: ENABLE_TOPOLOGY
valueFrom:
configMapKeyRef:
key: enable_topology
name: cloud-conf
volumeMounts:
- name: kubelet-dir
mountPath: /var/lib/kubelet
Expand Down