OCPBUGS-56128: openstack-cinder: Set --with-topology flag for node driver also #383
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@stephenfin: This pull request references Jira Issue OCPBUGS-56128, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stephenfin: This pull request references Jira Issue OCPBUGS-56128, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.19 |
|
@stephenfin: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…iver also Failure to do so results in the node driver reporting topology information which the provisioner respects, preventing us attaching the created volume. Signed-off-by: Stephen Finucane <[email protected]>
|
Failures were because I forgot to run |
|
@stephenfin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit d096201
into
openshift:main
|
@stephenfin: Jira Issue OCPBUGS-56128: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-56128 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stephenfin: new pull request created: #384 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-azure-disk-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: azure-file-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: csi-driver-manila-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-openstack-cinder-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-ebs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-smb-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-efs-csi-driver-operator |
This is a follow-up to #345. Failure to do so results in the node driver reporting topology information which the provisioner respects, preventing us attaching the created volume.