Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update modality handling in harmony_knn workflow #988

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

dorien-er
Copy link
Contributor

@dorien-er dorien-er commented Mar 24, 2025

Changelog

Update modality handling: only process RNA modality

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@dorien-er dorien-er added this to the 2.1.0 milestone Mar 28, 2025
Copy link
Member

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting nitpick, LGTM otherwise!

@dorien-er dorien-er merged commit eed8126 into main Apr 1, 2025
3 checks passed
@rcannood rcannood deleted the harmony-modality-handling branch April 7, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants