make gene name sanitation optional #1084
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesSchaumont
requested changes
Oct 17, 2025
| description: | | ||
| The minimum number of genes present in both the reference and query datasets. | ||
| - name: "--sanitize_gene_names" |
There was a problem hiding this comment.
Does this only remove version numbers? In this case I would use
--var_names_remove_ensembl_version_number or something like that
There was a problem hiding this comment.
It depends on what is passed to --var_gene_names: if this field contains ensemblid's, it would indeed only remove version numbers. But if this field contains gene symbols, it would result in removing splice variants
DriesSchaumont
requested changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Make gene name sanitation optional:
recommended for removing versions from ensembleid's (e.g. ENSMUSG00000017167.6), but not for gene names with splice variants (e.g. AL627309.1)
Note: #1083 needs to be merged first
Issue ticket number and link
Closes #xxxx (Replace xxxx with the GitHub issue number)
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!