Skip to content

Conversation

dorien-er
Copy link
Contributor

@dorien-er dorien-er commented Sep 16, 2025

Changelog

... Describe your changes ...

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes scGPT components and workflows from the codebase. The change appears to be a cleanup effort to deprecate and remove all scGPT-related functionality, which includes both integration and annotation workflows, along with their underlying components for tokenization, embedding generation, binning, and cell type annotation.

Key changes:

  • Complete removal of scGPT integration and annotation workflows
  • Deletion of all scGPT component modules (pad_tokenize, embedding, cross_check_genes, cell_type_annotation, binning)
  • Removal of scGPT test resource generation scripts
  • Addition of deprecation notice in CHANGELOG.md

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/workflows/integration/scgpt_leiden/ Removed complete integration workflow for scGPT with Leiden clustering
src/workflows/annotation/scgpt_annotation/ Removed complete annotation workflow using scGPT models
src/scgpt/* Removed all scGPT component modules and their implementations
resources_test_scripts/scgpt.sh Removed test resource generation script for scGPT components
CHANGELOG.md Added deprecation notice for scGPT functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be inclined to move the CHANGELOG to experimental? Otherwise I would be inclined to only release this in 4.0. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants