Fix normalization checks #1072
Open
Fix normalization checks #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesSchaumont
requested changes
Oct 3, 2025
| row_sums = layer.sum(axis=1) | ||
| exp_row_sums = exp_layer.sum(axis=1) | ||
|
|
||
| is_normalized = np.allclose(row_sums, 1) |
There was a problem hiding this comment.
I don't think is_normalized is asserted correctly here. Normalization scales the raw counts such that the sum of the counts for each cell are equal to a number. With CPM (counts per million) this is number is 1 milion, but the scanpy method is to use the median of total counts before normalization. So this number can differ, its not just 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
... Describe your changes ...
Issue ticket number and link
Closes #xxxx (Replace xxxx with the GitHub issue number)
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI tests succeed!