Skip to content

Improve error handling in Writable stream #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2025
Merged

Improve error handling in Writable stream #1035

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36b578a
Improve error handling in Writable stream
mhart Nov 11, 2025
4eb3cb9
Fix typing
mhart Nov 11, 2025
f690ee3
Fix typings again!
mhart Nov 11, 2025
9c1611b
Improve error handling in Writable stream
conico974 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/open-next/src/overrides/wrappers/cloudflare-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ const handler: WrapperHandler<InternalEvent, InternalResult> =

return new Writable({
write(chunk, encoding, callback) {
controller.enqueue(chunk);
try {
controller.enqueue(chunk);
} catch (e: any) {
return callback(e);
}
callback();
},
final(callback) {
Expand Down