Improve error handling in Writable stream #1035
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure errors are correctly handled in the Writable stream write. Previously this would throw an unhandled exception if the response stream had closed (eg, connection had been terminated). This is handled correctly if Node.js 24 stream behaviour is used, but not Node.js 22 or earlier. Returning the callback with the error ensures consistent behaviour for all Node.js versions (or compat versions)
|
commit: |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
conico974
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure errors are correctly handled in the Writable stream write.
Previously this would throw an unhandled exception if the response stream had closed (eg, connection had been terminated). This is handled correctly if Node.js 24 stream behaviour is used, but not Node.js 22 or earlier.
Returning the callback with the error ensures consistent behaviour for all Node.js versions (or compat versions)