-
Notifications
You must be signed in to change notification settings - Fork 42
8366432: Post-merge aarch64 build fixes #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8366432: Post-merge aarch64 build fixes #232
Conversation
|
👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into |
|
/contributor add @Bhavana-Kilambi |
|
@jatin-bhateja This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
@jatin-bhateja |
|
@jatin-bhateja This pull request has not yet been marked as ready for integration. |
|
Hi @XiaohongGong , @sviswa7 , @PaulSandoz Best Regards, |
XiaohongGong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your fixing!
|
/integrate |
|
Going to push as commit b09bdb3. |
|
@jatin-bhateja Pushed as commit b09bdb3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Follow-up patch for post-merger AArch64 build fixes
#230 (comment)
Validated on Google AXION, all JTreg tests are passing on AArch64 as well.
Best regards,
Jatin
Progress
Issue
Reviewers
Contributors
<[email protected]>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/panama-vector.git pull/232/head:pull/232$ git checkout pull/232Update a local copy of the PR:
$ git checkout pull/232$ git pull https://git.openjdk.org/panama-vector.git pull/232/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 232View PR using the GUI difftool:
$ git pr show -t 232Using diff file
Download this PR as a diff file:
https://git.openjdk.org/panama-vector/pull/232.diff
Using Webrev
Link to Webrev Comment