Skip to content

Conversation

@jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Aug 29, 2025

Follow-up patch for post-merger AArch64 build fixes
#230 (comment)

Validated on Google AXION, all JTreg tests are passing on AArch64 as well.

Best regards,
Jatin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8366432: Post-merge aarch64 build fixes (Enhancement - P4)

Reviewers

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-vector.git pull/232/head:pull/232
$ git checkout pull/232

Update a local copy of the PR:
$ git checkout pull/232
$ git pull https://git.openjdk.org/panama-vector.git pull/232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 232

View PR using the GUI difftool:
$ git pr show -t 232

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-vector/pull/232.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2025

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into vectorIntrinsics+fp16 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jatin-bhateja
Copy link
Member Author

/contributor add @Bhavana-Kilambi

@openjdk
Copy link

openjdk bot commented Aug 29, 2025

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366432: Post-merge aarch64 build fixes

Co-authored-by: Bhavana Kilambi <[email protected]>
Reviewed-by: xgong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics+fp16 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the vectorIntrinsics+fp16 branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 29, 2025

@jatin-bhateja
Contributor Bhavana Kilambi <[email protected]> successfully added.

@jatin-bhateja jatin-bhateja changed the title Post-merge aarch64 build fixes. 8366432: Post-merge aarch64 build fixes Aug 29, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 29, 2025
@jatin-bhateja jatin-bhateja mentioned this pull request Aug 29, 2025
2 tasks
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 29, 2025

@jatin-bhateja This pull request has not yet been marked as ready for integration.

@jatin-bhateja
Copy link
Member Author

jatin-bhateja commented Sep 1, 2025

Hi @XiaohongGong , @sviswa7 , @PaulSandoz
Can you kindly approve this, me being patch author cannot approve this PR and seek approval from another panama committer.

Best Regards,
Jatin

Copy link
Collaborator

@XiaohongGong XiaohongGong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your fixing!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 1, 2025
@jatin-bhateja
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

Going to push as commit b09bdb3.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2025
@openjdk openjdk bot closed this Sep 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2025
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@jatin-bhateja Pushed as commit b09bdb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants