Skip to content

Conversation

@jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Aug 20, 2025

Merge vectorIntrinsics into vectorIntrinsics+fp16 as per the proposal on panama-dev mailing list[1]. This was a major merge after a gap of 2+ years.

Summary of changes:-

  • Added a new package-private field CTYPE (carrier type) along with existing ETYPE (element type) to differentiate b/w the storage type from the vector lane element type.
  • Pass an explicit operType argument to inline expanders to ease inferencing of Float16 vector IR. Idea: leverage existing backend implementation added along with JDK-8346236[2] and [3]
  • Appropriate modifications in existing inline expansion entry points and VectorSupport class.
  • Replaced existing Halffloat class references with jdk.incubator.vector.Float16, along with appropriate API adjustments.

What is remaining:-

  • Use the newly passed operType to infer Float16 Vector IR.
  • Functional validation
  • Performance validation

[1] https://mail.openjdk.org/pipermail/panama-dev/2025-August/021100.html
[2] openjdk/jdk#22755
[3] openjdk/jdk#22754


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-vector.git pull/230/head:pull/230
$ git checkout pull/230

Update a local copy of the PR:
$ git checkout pull/230
$ git pull https://git.openjdk.org/panama-vector.git pull/230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 230

View PR using the GUI difftool:
$ git pr show -t 230

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-vector/pull/230.diff

Using Webrev

Link to Webrev Comment

Alexander Zvegintsev and others added 30 commits July 31, 2025 06:04
Reviewed-by: psadhukhan, serb, prr, kizune, kcr
…lasses consistently

Reviewed-by: stuefe, ayang, coleenp
…e" property value for sun/net/www/protocol/file/FileURLTest.java

Reviewed-by: vyazici, rriggs
Reviewed-by: rgiulietti, rriggs, vyazici
…c at the end of marking phase

Reviewed-by: dholmes
Reviewed-by: shade, iklam
…rows clause of a constructor

Reviewed-by: nbenalla, liach
Co-authored-by: Alexey Ivanov <[email protected]>
Reviewed-by: dnguyen, abhiscxk
@jatin-bhateja jatin-bhateja marked this pull request as ready for review August 22, 2025 16:16
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2025

Webrevs

@jatin-bhateja
Copy link
Member Author

I plan to address remaining items along with JDK-8365967 in a follow-up patch.

@openjdk
Copy link

openjdk bot commented Aug 22, 2025

@jatin-bhateja
The label panama is not a valid label.
These labels are valid:

@jatin-bhateja
Copy link
Member Author

image

@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2025
@jatin-bhateja
Copy link
Member Author

jatin-bhateja commented Aug 28, 2025

With the latest bug-fix commit, all VectorAPI jtreg tests, including new HalffloatVectorTest are passing on AVX512 and AVX2 targets. HalffloatVectorTests are currently running at compilation tier=3, we will lift this limitation along with JDK-8365967

What is remaining?

  • AArch64 build fixes.
  • The following two IR framework test failures unrelated to Float16 support need to be analyzed.
    • compiler.vectorapi.VectorMultiplyOpt
    • compiler.vectorapi.TestVectorRotateScalarCount.

I plan to address IR framework test failures along with PR/231

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2025
@Bhavana-Kilambi
Copy link
Contributor

fix_aarch64_build_failures.patch

Hi Jatin, please find attached the diff file to fix the build failures on aarch64. The build now passes on aarch64.

@mlbridge
Copy link

mlbridge bot commented Aug 29, 2025

Mailing list message from Jatin Bhateja on panama-dev:

Thanks, Bhavana,

I verified on Google AXION that all VectorAPI jtreg tests are now
passing on AARCH64 as well.

Best Regards,

Jatin

On 8/29/2025 2:39 PM, Bhavana Kilambi wrote:

@jatin-bhateja
Copy link
Member Author

jatin-bhateja commented Aug 29, 2025

Adding @Bhavana-Kilambi as a co-contributor for AARCH64 build failure fixes, I will integrate the aarch64 build fix patch separately along with #232

@jatin-bhateja
Copy link
Member Author

/contributor add @Bhavana-Kilambi

@openjdk
Copy link

openjdk bot commented Aug 29, 2025

@jatin-bhateja
Contributor Bhavana Kilambi <[email protected]> successfully added.

@jatin-bhateja
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 29, 2025

Going to push as commit 7fdcfe5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2025
@openjdk openjdk bot closed this Aug 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 29, 2025
@openjdk
Copy link

openjdk bot commented Aug 29, 2025

@jatin-bhateja Pushed as commit 7fdcfe5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jatin-bhateja jatin-bhateja deleted the merge_vectorIntrinsics branch October 1, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.