-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372353: API to compute the byte length of a String encoded in a given Charset #28454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cushon
wants to merge
1
commit into
openjdk:master
Choose a base branch
from
cushon:strlen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+208
−1
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
test/micro/org/openjdk/bench/java/lang/foreign/StringLoopJmhBenchmark.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,121 @@ | ||||||||||||||||||||
| /* | ||||||||||||||||||||
| * Copyright (c) 2025, Google LLC. All rights reserved. | ||||||||||||||||||||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * This code is free software; you can redistribute it and/or modify it | ||||||||||||||||||||
| * under the terms of the GNU General Public License version 2 only, as | ||||||||||||||||||||
| * published by the Free Software Foundation. | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||||||||||||||||||||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||||||||||||||||||||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||||||||||||||||||||
| * version 2 for more details (a copy is included in the LICENSE file that | ||||||||||||||||||||
| * accompanied this code). | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * You should have received a copy of the GNU General Public License version | ||||||||||||||||||||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||||||||||||||||||||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||||||||||||||||||||
| * | ||||||||||||||||||||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||||||||||||||||||||
| * or visit www.oracle.com if you need additional information or have any | ||||||||||||||||||||
| * questions. | ||||||||||||||||||||
| */ | ||||||||||||||||||||
| package org.openjdk.bench.java.lang.foreign; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| import java.nio.charset.StandardCharsets; | ||||||||||||||||||||
| import java.util.concurrent.TimeUnit; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.Benchmark; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.BenchmarkMode; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.Fork; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.Measurement; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.Mode; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.OutputTimeUnit; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.Param; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.Scope; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.Setup; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.Warmup; | ||||||||||||||||||||
| import org.openjdk.jmh.annotations.State; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| @Warmup(time = 1, timeUnit = TimeUnit.SECONDS) | ||||||||||||||||||||
| @Measurement(time = 1, timeUnit = TimeUnit.SECONDS) | ||||||||||||||||||||
| @Fork(1) | ||||||||||||||||||||
| @State(Scope.Benchmark) | ||||||||||||||||||||
| public class StringLoopJmhBenchmark { | ||||||||||||||||||||
| @Param({"10", "100", "1000", "100000"}) | ||||||||||||||||||||
| int stringLength; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| @Param({"ASCII", "LATIN1", "UTF16"}) | ||||||||||||||||||||
| String encoding; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| String stringData; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| @Setup | ||||||||||||||||||||
| public void setUp() { | ||||||||||||||||||||
| stringData = ""; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| // Character at the _end_ to affect if we hit | ||||||||||||||||||||
| // - ASCII = compact strings and compatible with UTF-8 | ||||||||||||||||||||
| // - LATIN1 = compact strings but not compatible with UTF-8 | ||||||||||||||||||||
| // - UTF16 = 2-byte char storage and not compatible with UTF-8 | ||||||||||||||||||||
| String c; | ||||||||||||||||||||
| if (encoding.equals("ASCII")) { | ||||||||||||||||||||
| c = "a"; | ||||||||||||||||||||
| } else if (encoding.equals("LATIN1")) { | ||||||||||||||||||||
| c = "\u00C4"; | ||||||||||||||||||||
| } else if (encoding.equals("UTF16")) { | ||||||||||||||||||||
| c = "\u2603"; | ||||||||||||||||||||
| } else { | ||||||||||||||||||||
| throw new IllegalArgumentException("Unknown encoding: " + encoding); | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| while (stringData.length() < stringLength) { | ||||||||||||||||||||
| stringData += (char) (Math.random() * 26) + 'a'; | ||||||||||||||||||||
| } | ||||||||||||||||||||
| stringData += c; | ||||||||||||||||||||
|
Comment on lines
+71
to
+74
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe avoid creating intermediate strings in a loop to avoid excess GC pressure?
Suggested change
|
||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| @Benchmark | ||||||||||||||||||||
| public int utf8LenByLoop() { | ||||||||||||||||||||
| final String s = stringData; | ||||||||||||||||||||
| final int len = s.length(); | ||||||||||||||||||||
|
|
||||||||||||||||||||
| // ASCII prefix strings. | ||||||||||||||||||||
| int idx = 0; | ||||||||||||||||||||
| for (char c; idx < len && (c = s.charAt(idx)) < 0x80; ++idx) {} | ||||||||||||||||||||
|
|
||||||||||||||||||||
| // Entire string was ASCII. | ||||||||||||||||||||
| if (idx == len) { | ||||||||||||||||||||
| return len; | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| int utf8Len = len; | ||||||||||||||||||||
| for (char c; idx < len; ++idx) { | ||||||||||||||||||||
| c = s.charAt(idx); | ||||||||||||||||||||
| if (c < 0x80) { | ||||||||||||||||||||
| utf8Len++; | ||||||||||||||||||||
| } else if (c < 0x800) { | ||||||||||||||||||||
| utf8Len += 2; | ||||||||||||||||||||
| } else { | ||||||||||||||||||||
| utf8Len += 3; | ||||||||||||||||||||
| if (Character.isSurrogate(c)) { | ||||||||||||||||||||
| int cp = Character.codePointAt(s, idx); | ||||||||||||||||||||
| if (cp < Character.MIN_SUPPLEMENTARY_CODE_POINT) { | ||||||||||||||||||||
| throw new RuntimeException("Unpaired surrogate"); | ||||||||||||||||||||
| } | ||||||||||||||||||||
| idx++; | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
| return utf8Len; | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| @Benchmark | ||||||||||||||||||||
| public int getBytes() throws Exception { | ||||||||||||||||||||
| return stringData.getBytes(StandardCharsets.UTF_8).length; | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
|
||||||||||||||||||||
| @Benchmark | ||||||||||||||||||||
| public int getBytesLength() throws Exception { | ||||||||||||||||||||
| return stringData.getBytesLength(StandardCharsets.UTF_8); | ||||||||||||||||||||
| } | ||||||||||||||||||||
| } | ||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the BOM‑less UTF‑16 charsets, this can simply return
value.length << (1 ‑ coder())1:Footnotes
Lone surrogates get replaced with
U+FFFDwhen encoding to UTF‑16 byString::getBytes(Charset), and all of LATIN1 can be encoded in UTF‑16. ↩