8372353: API to compute the byte length of a String encoded in a given Charset #28454
+208
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
ExE-Boss
reviewed
Nov 22, 2025
| if (bytesCompatible(cs)) { | ||
| return value.length; | ||
| } | ||
| return getBytes(cs).length; |
There was a problem hiding this comment.
For the BOM‑less UTF‑16 charsets, this can simply return value.length << (1 ‑ coder())1:
Suggested change
| return getBytes(cs).length; | |
| if (cs instanceof sun.nio.cs.UTF_16LE || | |
| cs instanceof sun.nio.cs.UTF_16BE) { | |
| return value.length << (1 - coder()); | |
| } | |
| return getBytes(cs).length; |
Footnotes
-
Lone surrogates get replaced with
U+FFFDwhen encoding to UTF‑16 byString::getBytes(Charset), and all of LATIN1 can be encoded in UTF‑16. ↩
ExE-Boss
reviewed
Nov 22, 2025
Comment on lines
+71
to
+74
| while (stringData.length() < stringLength) { | ||
| stringData += (char) (Math.random() * 26) + 'a'; | ||
| } | ||
| stringData += c; |
There was a problem hiding this comment.
Maybe avoid creating intermediate strings in a loop to avoid excess GC pressure?
Suggested change
| while (stringData.length() < stringLength) { | |
| stringData += (char) (Math.random() * 26) + 'a'; | |
| } | |
| stringData += c; | |
| var stringDataBuilder = new StringBuilder(stringLength + 1); | |
| while (stringDataBuilder.length() < stringLength) { | |
| stringDataBuilder.append((char) (Math.random() * 26) + 'a'); | |
| } | |
| stringData = stringDataBuilder.append(c).toString(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an API to return the byte length of a String encoded in a given charset. See JDK-8372353 for background.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28454/head:pull/28454$ git checkout pull/28454Update a local copy of the PR:
$ git checkout pull/28454$ git pull https://git.openjdk.org/jdk.git pull/28454/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28454View PR using the GUI difftool:
$ git pr show -t 28454Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28454.diff