8356036: (fs) FileKey.hashCode and UnixFileStore.hashCode implementations can use Long.hasCode

[wenshao]

Similar to #24959 and #24971, sun.nio.ch.FileKey/sun.nio.fs.UnixFileKey/sun.nio.fs.UnixFileStore in java.base can also be simplified similarly.

Replace manual bitwise operations in hashCode implementations of sun.nio.ch.FileKey/sun.nio.fs.UnixFileKey/sun.nio.fs.UnixFileStore with Long::hashCode.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8356036: (fs) FileKey.hashCode and UnixFileStore.hashCode implementations can use Long.hasCode (Enhancement - P5)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24987/head:pull/24987
$ git checkout pull/24987

Update a local copy of the PR:
$ git checkout pull/24987
$ git pull https://git.openjdk.org/jdk.git pull/24987/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24987

View PR using the GUI difftool:
$ git pr show -t 24987

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24987.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wenshao This change is no longer ready for integration - check the PR body for details.

[openjdk]

@wenshao The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[liach]

Confirmed all replaced variables are long. And they are all final long fields, so we can ignore the double field read in race effects (and long even permits tearing reads)

[mlbridge]

Webrevs

• 00: Full (ca5a9cfa)

[AlanBateman]

/reviewers 2

[openjdk]

@AlanBateman
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[AlanBateman]

Needs to reviewed by maintainer in this area.

[liach]

/reviewers 2 reviewer

[openjdk]

@liach
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).