8356044: Use Double::hashCode and Long::hashCode in java.vm.ci.meta #24988
+3
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #24959 and #24971 and #24987, AbstractProfiledItem/PrimitiveConstant in java.vm.ci.meta can also be simplified similarly.
Replace manual bitwise operations in hashCode implementations of java.vm.ci.meta.AbstractProfiledItem/java.vm.ci.meta.PrimitiveConstant with Long::hashCode/Double.hashCode.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24988/head:pull/24988
$ git checkout pull/24988
Update a local copy of the PR:
$ git checkout pull/24988
$ git pull https://git.openjdk.org/jdk.git pull/24988/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24988
View PR using the GUI difftool:
$ git pr show -t 24988
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24988.diff
Using Webrev
Link to Webrev Comment