change authorization_details to use credential_description from metadata
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to the name of a `credentials_supported` object in the Credential Issuer's Metadata
paulbastian
requested review from
tlodderstedt and
Sakurann
and removed request for
tlodderstedt
Sakurann
reviewed
Dec 8, 2023
Sakurann
reviewed
Dec 8, 2023
Sakurann
reviewed
Dec 8, 2023
peppelinux
approved these changes
Dec 9, 2023
|
I fully support this PR, it simplifies a lot by requiring the proper evaluation of the credential issuer metadata. This is a basic requirement that with the approach proposed in this PR is made stronger than before in the material implementations, removing any repetitions of values which consequently require further checks |
Co-authored-by: Kristina <[email protected]>
Co-authored-by: Kristina <[email protected]>
peppelinux
requested changes
Dec 12, 2023
peppelinux
approved these changes
Dec 13, 2023
peppelinux
approved these changes
Dec 13, 2023
Sakurann
approved these changes
Dec 14, 2023
jogu
approved these changes
Dec 14, 2023
awoie
reviewed
Dec 14, 2023
awoie
reviewed
Dec 14, 2023
awoie
reviewed
Dec 14, 2023
awoie
reviewed
Dec 14, 2023
paulbastian
commented
Dec 14, 2023
paulbastian
commented
Dec 14, 2023
agreed on in DCP call
bc-pi
reviewed
Dec 14, 2023
Co-authored-by: Brian Campbell <[email protected]>
peppelinux
reviewed
Dec 15, 2023
…etadata-in-authorization_details-authorization-request-parameter
|
@Sakurann @jogu @peppelinux I went through the whole document again and saw that I've overseen some text in the Appendix E, therefore please review again. |
peppelinux
approved these changes
Dec 17, 2023
|
Given that there seems to not be much of a controversy on the terminology proposed in #155, I wonder if we should go for |
awoie
approved these changes
Dec 19, 2023
…etadata-in-authorization_details-authorization-request-parameter
tlodderstedt
approved these changes
Dec 22, 2023
6 approvals. general agreement to merge this during Dec-21-2023 WG call. some comments remain to be addressed in other PRs (mainly 155), as this PR is scoped to change the parameter name changes and not to have a perfect terminology. * change to credential_configuration_id * change to credential_configurations_offered * rename to credential_configurations_supported * Apply suggestions from code review Co-authored-by: Giuseppe De Marco <[email protected]> Co-authored-by: Daniel Fett <[email protected]> * rename to credential_configurations credential offer parameter * clarify there is no polymorphism Co-authored-by: Oliver Terbu <[email protected]> * editorial --------- Co-authored-by: Kristina <=> Co-authored-by: Giuseppe De Marco <[email protected]> Co-authored-by: Daniel Fett <[email protected]> Co-authored-by: Oliver Terbu <[email protected]>
…etadata-in-authorization_details-authorization-request-parameter
Sakurann
approved these changes
Dec 22, 2023
Sakurann
pushed a commit
that referenced
this pull request
Dec 22, 2023
editorial This was missed in #137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102
Changes
authorization_detailsto usecredential_descriptionpointing to the name of acredentials_supportedobject in the Credential Issuer's Metadata.