New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: OpenID4VCI Draft 13 #175

Merged

peppelinux merged 24 commits into versione-corrente from vci-ref

Jan 3, 2024

Member

peppelinux commented Dec 12, 2023 •

edited

Loading

This PR:

includes missing terms in the section Define terms
Closes [OpenID4VCI] Token response and Credential Request changes #153
Closes [OpenID4VCI] credentials_supported #151
Closes [AS Metadata] authorization_servers must be an array #148

~~The following PR https://github.com/italia/eudi-wallet-it-docs/pull/170/files included changes considered needed in this PR, however, having them in a separate PR these was not included in this PR.~~ -> RAR schema changed in openid4vci.

This PR also anticipates this https://github.com/openid/OpenID4VCI/pull/87/files

peppelinux added 4 commits

December 12, 2023 13:23


          fix: Defined terms and editorial on issuance introduction

a2dbf74


          Issuance: detailed flow up to the federation discovery

d195be5


          fix: issuance according to OpenID4VCI Draft 13

17c0cee


          fix!: issuance - credential_supported schema

fdec6f4

peppelinux requested review from balanza, grausof and fmarino-ipzs

December 12, 2023 16:14

peppelinux added 7 commits

December 12, 2023 17:20


          fix: issuance - request object reordiering members

dcb6bd9


          fix!: issuance - authorization_servers in the metadata - Closes #148

0aab13e


          chore: issuance - added proof_types_supported in the metadata

718f524


          fix: issuance - metadata - proof types mandatory - according to https…

15384dc

…://github.com/openid/OpenID4VCI/pull/87/files


          fix: remove NRA

0d139d7


          editorials: OpenID Connect Core 1.0 or SAML2

692c6a8


          fix: WIA~POP removed from token endpoint

9e00eb9

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux added 3 commits

December 12, 2023 21:06


          fix: WIA~POP removed from token endpoint

ef0c330


          fix: credential_definition.type is an ARRAY

70bd6b1


          fix: editorial on vci metadata

120c1f4

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

Sh-Amir reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

Sh-Amir reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

Sh-Amir reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

Sh-Amir suggested changes

View reviewed changes

Collaborator

Sh-Amir left a comment

I left some suggestions to make some changes. Please have a look.

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved


          Apply suggestions from code review with Amir

2737fbb

Co-authored-by: asharif1990 <[email protected]>

peppelinux requested a review from Sh-Amir

December 15, 2023 13:19

peppelinux and others added 4 commits

December 28, 2023 11:52


          fix!: alignments according to breaking changes introduced by openid4v…

cd80152

…ci I-D


          Merge branch 'vci-ref' of https://github.com/italia/eidas-it-wallet-docs

3a1f5b4

 into vci-ref


          fix!: alignments according to breaking changes introduced by openid4v…

5f86556

…ci I-D - ff


          Merge branch 'versione-corrente' into vci-ref

432e3c5

fmarino-ipzs reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved


          Apply suggestions from code review

bc5a170

Co-authored-by: fmarino-ipzs <[email protected]>

fmarino-ipzs reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

fmarino-ipzs reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

fmarino-ipzs reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Show resolved Hide resolved

fmarino-ipzs approved these changes

View reviewed changes

Sh-Amir reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

Sh-Amir reviewed

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved

Sh-Amir suggested changes

View reviewed changes

Collaborator

Sh-Amir left a comment

some minor changes.

peppelinux commented

View reviewed changes

docs/en/pid-eaa-issuance.rst Outdated Show resolved Hide resolved


          Apply suggestions from code review

3cecbe6

Co-authored-by: asharif1990 <[email protected]>
Co-authored-by: fmarino-ipzs <[email protected]>

peppelinux requested a review from Sh-Amir

December 30, 2023 12:07

Sh-Amir approved these changes

View reviewed changes

Sh-Amir approved these changes

View reviewed changes


          Merge branch 'versione-corrente' into vci-ref

610bc9e

grausof approved these changes

View reviewed changes

peppelinux merged commit 119cbad into versione-corrente

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet