-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add localized additives and allergens #929
feat: add localized additives and allergens #929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @goerlitz!
I suspect you haven't formatted your code AND you haven't either run the code generation process: dart run build_runner build
.
Please run it and push your code.
Ooops, was a formatting issue. Should be fixed now. |
@goerlitz We may look rather relaxed about failing tests, but it's just an impression. |
I'll take a look. When I ran |
I can understand that. |
Alright, the test did not fetch all data needed for the comparison. Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @goerlitz, thank you and congratulations for your first contribution here!
For the record you should have run the JSON related code generator instead of writing into a // GENERATED CODE - DO NOT MODIFY BY HAND
file.
Your code will probably be replaced by the generated code anyway, though from what I read it's highly likely that there will be no real difference.
thanks
I actually ran |
I assume that the code generator generates a formatted result. And as your push is named "fix code formatting", it gives the impression that you manually formatted the code, not that you used the code generator. |
Ah, that's what you mean. |
What
Add support for getting localized additives and allergens
Fixes
#928