Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ADDITIVES_TAGS_IN_LANGUAGES and ALLERGENS_TAGS_IN_LANGUAGES #928

Closed
goerlitz opened this issue May 14, 2024 · 2 comments
Closed

Comments

@goerlitz
Copy link
Contributor

Why - Problem description

Currently, it is not possible to execute following API request because in ProductField the required
ADDITIVES_TAGS_IN_LANGUAGES and ALLERGENS_TAGS_IN_LANGUAGES field definitions are missing.

https://de.openfoodfacts.org/api/v2/product/20101268?fields=additives_tags_de,additives_tags_en,allergens_tags_de,allergens_tags_en

Moreover, the existing ADDITIVES(offTag: 'additives_tags') and ALLERGENS(offTag: 'allergens_tags') do not follow the existing naming convention - they should be named ADDITIVES_TAGS and ALLERGENS_TAGS.

What - Proposed solution

Add ADDITIVES_TAGS_IN_LANGUAGES and ALLERGENS_TAGS_IN_LANGUAGES and the logic to handle these fields properly.

@goerlitz
Copy link
Contributor Author

@monsieurtanuki I just implemented the feature. Would be great if you can have a look.

@monsieurtanuki
Copy link
Contributor

Fixed in #929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants