fix: fixed unit tests #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `api_get_save_product_test.dart`: moved there read-write tests from `api_get_product_test.dart` Impacted files: * `api_add_product_image_test.dart`: skipped tests on unreliable TEST env * `api_get_product_test.dart`: now we're focused on read-only tests in PROD; we moved the read-write tests to new file `api_get_save_product_test.dart` * `api_get_robotoff_test.dart`: fixed special cases with specific insight types * `api_get_to_be_completed_products_test.dart`: added a filter on stores for less demanding queries * `api_ocr_ingredients_test.dart`: fixed async tests with no await * `api_search_products_test.dart`: added a filter in order to make the query less server intensive - and less prone to server crash
Merged
g123k
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Files
New file:
api_get_save_product_test.dart: moved there read-write tests fromapi_get_product_test.dartImpacted files:
api_add_product_image_test.dart: skipped tests on unreliable TEST envapi_get_product_test.dart: now we're focused on read-only tests in PROD; we moved the read-write tests to new fileapi_get_save_product_test.dartapi_get_robotoff_test.dart: fixed special cases with specific insight typesapi_get_to_be_completed_products_test.dart: added a filter on stores for less demanding queriesapi_ocr_ingredients_test.dart: fixed async tests with no awaitapi_search_products_test.dart: added a filter in order to make the query less server intensive - and less prone to server crash