Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release #747

Merged
merged 1 commit into from
Jul 12, 2023
Merged

ci: release #747

merged 1 commit into from
Jul 12, 2023

Conversation

M123-dev
Copy link
Member

The release was not triggered due to GitHub's recursive run protection. Now we releases using the Openfoodfacts-bot account

The release was not triggered due to GitHub's recursive run protection. Now we releases using the Openfoodfacts-bot account
@M123-dev M123-dev requested review from alexgarel and teolemon June 16, 2023 07:46
@M123-dev M123-dev requested a review from a team as a code owner June 16, 2023 07:46
@M123-dev M123-dev changed the title Fix: release fix: release Jun 16, 2023
@M123-dev M123-dev changed the title fix: release ci: release Jun 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #747 (9d108c8) into master (b6f41cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #747   +/-   ##
=======================================
  Coverage   75.09%   75.09%           
=======================================
  Files         201      201           
  Lines        7373     7373           
=======================================
  Hits         5537     5537           
  Misses       1836     1836           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@M123-dev
Copy link
Member Author

@monsieurtanuki @g123k we need this merged to make the release work again

@g123k g123k merged commit 94559a3 into master Jul 12, 2023
@g123k g123k deleted the M123-dev-patch-1 branch July 12, 2023 08:50
@M123-dev
Copy link
Member Author

I am on vacation right now, so I am not able to manually release 2.7.0 but the next release PR should work now

@g123k
Copy link
Contributor

g123k commented Jul 12, 2023

Is it OK if I upload it manually?
Because a new PR will be 2.8.0, isn't it?

@monsieurtanuki
Copy link
Contributor

Because a new PR will be 2.8.0, isn't it?

I don't think anyone would complain about a missing 2.7.0.
And with a phoney 2.8.0 we'll test the new release process. @g123k You may approve #755 - I cannot say it's the most spectacular PR ever written but that would be good enough for the moment.
@M123-dev Enjoy your holiday! Still in Italy?

@g123k
Copy link
Contributor

g123k commented Jul 12, 2023

It looks like it's still broken, with an issue with the token: https://github.com/openfoodfacts/openfoodfacts-dart/actions/runs/5531012328?pr=757

@monsieurtanuki
Copy link
Contributor

I can't be helpful here.

@M123-dev
Copy link
Member Author

I was about to say it is fixed, I have talked to Alex about that pat and did some pub.dev config but it seems we have to update the workflow in some way

@g123k
Copy link
Contributor

g123k commented Jul 13, 2023

I was about to say it is fixed, I have talked to Alex about that pat and did some pub.dev config but it seems we have to update the workflow in some way

Ok for the workflow. But in the meantime, is-it possible to manually push it somehow?
I need the two features on the app and I'm already stuck for a few days.

@M123-dev
Copy link
Member Author

@peterwvj could you help here, doing a manual release of the latest master

@stephanegigandet
Copy link
Contributor

I just made a manual release.

Successfully uploaded https://pub.dev/packages/openfoodfacts version 2.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants