fix(controller): prevent zfs volume cr deletion if snapshot exists #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
sinhaashish
requested review from
tiagolobocastro,
niladrih and
Abhinandan-Purkait
sinhaashish
force-pushed
the
stop-deletion-of-snapshot-upon-pvc-deletion
branch
25 times, most recently
from
ab7ac7e to
2ef74a3
Compare
sinhaashish
force-pushed
the
stop-deletion-of-snapshot-upon-pvc-deletion
branch
from
2ef74a3 to
6fc2bd8
Compare
sinhaashish
force-pushed
the
stop-deletion-of-snapshot-upon-pvc-deletion
branch
from
6fc2bd8 to
5428395
Compare
ci/ci-test.sh
Outdated
| @@ -107,7 +107,7 @@ runTestSuite() { | |||
|
|
|||
| echo "running ginkgo test case with coverage ${coverageFile}" | |||
|
|
|||
| if ! ginkgo -v -coverprofile="${coverageFile}" --label-filter="${labelFilter}" -covermode=atomic; then | |||
| if ! ginkgo -p -v -coverprofile="${coverageFile}" --label-filter="${labelFilter}" -covermode=atomic; then | |||
There was a problem hiding this comment.
This runs the tests in parallel?
But it's still on the same cluster, is it better to split into different clusters?
tests/provision_test.go
Outdated
| deleteAppDeployment(cloneAppNameAlpha) | ||
|
|
||
| deletePVC(clonePvcNameAlpha) | ||
| deleteSnapshot(pvcNameAplha, snapNameAlpha) |
There was a problem hiding this comment.
Here we should check if the ZV CR has been deleted as well?
sinhaashish
force-pushed
the
stop-deletion-of-snapshot-upon-pvc-deletion
branch
from
5428395 to
bced0f3
Compare
sinhaashish
force-pushed
the
stop-deletion-of-snapshot-upon-pvc-deletion
branch
from
bced0f3 to
a48fcdb
Compare
7 tasks
tiagolobocastro
deleted the
stop-deletion-of-snapshot-upon-pvc-deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Upon pvc deletion the zfs snapshot also gets deleted. this can be verified using ssh into the node and running the command
zfs list -t allWhat this PR does?:
It stops deletion of CR if snapshot exists
Does this PR require any upgrade changes?:
no
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>