fix(controller): prevent zfs volume cr deletion if snapshot exists #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhaashish
force-pushed
the
stop-deletion
branch
2 times, most recently
from
a961d15 to
78048a5
Compare
|
@tiagolobocastro PR #607 is closed as there was some issue from my side while rebasing. I have created this PR with the same code base along with checking that ZV is present in the system as per your comment here. Splitting the test to run on different cluster can be taken sometime later. |
sinhaashish
requested review from
tiagolobocastro and
Abhinandan-Purkait
and removed request for
tiagolobocastro
sinhaashish
force-pushed
the
stop-deletion
branch
5 times, most recently
from
8e135cc to
39b0fc7
Compare
sinhaashish
force-pushed
the
stop-deletion
branch
from
39b0fc7 to
aa02172
Compare
sinhaashish
force-pushed
the
stop-deletion
branch
13 times, most recently
from
5eb7e8f to
54c716b
Compare
sinhaashish
force-pushed
the
stop-deletion
branch
11 times, most recently
from
ff1251d to
3d5c36a
Compare
sinhaashish
force-pushed
the
stop-deletion
branch
from
3d5c36a to
47da3ff
Compare
sinhaashish
force-pushed
the
stop-deletion
branch
2 times, most recently
from
7e8f590 to
2005206
Compare
|
Looks good to me mostly. Thanks for taking this up. Will approve once the test passes and the other comments are addressed. |
sinhaashish
force-pushed
the
stop-deletion
branch
3 times, most recently
from
46f95ef to
d0ae251
Compare
Abhinandan-Purkait
approved these changes
Feb 3, 2025
sinhaashish
force-pushed
the
stop-deletion
branch
from
d0ae251 to
0964543
Compare
sinhaashish
force-pushed
the
stop-deletion
branch
from
0964543 to
ab012d5
Compare
Signed-off-by: sinhaashish <[email protected]>
sinhaashish
force-pushed
the
stop-deletion
branch
from
ab012d5 to
94527d2
Compare
tiagolobocastro
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
Upon pvc deletion the zfs snapshot also gets deleted. this can be verified using ssh into the node and running the command zfs list -t all
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>