-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress e2e Test - Verify User Can Access Jupyter Launcher From DS Project Page #3553
Cypress e2e Test - Verify User Can Access Jupyter Launcher From DS Project Page #3553
Conversation
Hi @ConorOM1. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
frontend/src/__tests__/cypress/cypress/utils/oc_commands/baseCommands.ts
Outdated
Show resolved
Hide resolved
...c/__tests__/cypress/cypress/tests/e2e/dataScienceProjects/testLaunchStandaloneNotebook.cy.ts
Outdated
Show resolved
Hide resolved
...c/__tests__/cypress/cypress/tests/e2e/dataScienceProjects/testLaunchStandaloneNotebook.cy.ts
Outdated
Show resolved
Hide resolved
...c/__tests__/cypress/cypress/tests/e2e/dataScienceProjects/testLaunchStandaloneNotebook.cy.ts
Outdated
Show resolved
Hide resolved
f697aae
to
87de068
Compare
frontend/src/__tests__/cypress/cypress/utils/oc_commands/baseCommands.ts
Outdated
Show resolved
Hide resolved
/lgtm |
New changes are detected. LGTM label has been removed. |
c98efb8
to
b4c341c
Compare
New changes are detected. LGTM label has been removed. |
b4c341c
to
bb27abe
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manosnoam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
...c/__tests__/cypress/cypress/tests/e2e/dataScienceProjects/testLaunchStandaloneNotebook.cy.ts
Outdated
Show resolved
Hide resolved
...c/__tests__/cypress/cypress/tests/e2e/dataScienceProjects/testLaunchStandaloneNotebook.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/utils/oc_commands/baseCommands.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/utils/oc_commands/baseCommands.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Conor, I've added some minor comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
- Coverage 85.57% 85.16% -0.41%
==========================================
Files 1371 1380 +9
Lines 31180 31542 +362
Branches 8727 8818 +91
==========================================
+ Hits 26681 26863 +182
- Misses 4499 4679 +180
... and 304 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
09ad344
to
5007cb3
Compare
@ConorOM1 thanks for the latest changes, some good improvements. Can you check please check this also by running the test in Jenkins along with the other current tests? There is a step that opens a new tab which I've seen running the tests locally physically opened a new tab, we need to ensure that there are no unintended consequences of doing this to other tests. |
@antowaddle tested in Jenkins, looks good, no effect on other tests, videos, screenshots etc. Here: cypress/job/dashboard-tests/143/Test_20Reports/ |
/lgtm /approve |
https://issues.redhat.com/browse/RHOAIENG-12652
Description
Migrate ODS-1877 to Cypress with additional enhancements added
How Has This Been Tested?
An oc login should be performed in the cluster before running the test
test-variables.yml should be configured properly
Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
Tested against ODH-Nightly & RHOAI nightly
How to Run
After exporting the test-variables.yml we have 2 different ways:
Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testLaunchStandaloneNotebook.cy.ts can be run.
Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/testLaunchStandaloneNotebook.cy.ts" --browser chrome
Test Impact:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main