Skip to content

Commit

Permalink
linters addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
ConorOM1 committed Dec 12, 2024
1 parent 20ef620 commit 09ad344
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ describe('Verify a Jupyter Notebook can be launched directly from the Data Scien
// Verify that the server is running
cy.step('Verify the Jupyter Notebook pod is ready');
waitForPodReady('jupyter-nb', '300s');

// Expand the log
cy.step('Expand the Event log');
notebookServer.findEventlog().should('be.visible').click();
notebookServer.findEventlog().should('be.visible').click();

// Wait for the success alert
cy.step('Waits for the Success alert');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,14 @@ export const waitForPodReady = (
const ocCommand = `oc get pods ${namespaceFlag} --no-headers | awk '$2 ~ /^${podNameContains}/ {print $1, $2}' | xargs -tn2 oc wait --for=condition=Ready pod --timeout=${timeout} -n`;
cy.log(`Executing: ${ocCommand}`);

return cy.exec(ocCommand, { failOnNonZeroExit: false, timeout: 300000 }).then((result: CommandLineResult) => {
if (result.code !== 0) {
throw new Error(`Pod readiness check failed: ${result.stderr}`);
}
cy.log(`Pod is ready: ${result.stdout}`);
});
return cy
.exec(ocCommand, { failOnNonZeroExit: false, timeout: 300000 })
.then((result: CommandLineResult) => {
if (result.code !== 0) {
throw new Error(`Pod readiness check failed: ${result.stderr}`);
}
cy.log(`Pod is ready: ${result.stdout}`);
});
};

/**
Expand Down

0 comments on commit 09ad344

Please sign in to comment.