Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrating NIM model UI #3156

Merged
merged 1 commit into from
Sep 20, 2024

feat: integrating NIM model UI

ce486ae
Select commit
Loading
Failed to load commit list.
Merged

feat: integrating NIM model UI #3156

feat: integrating NIM model UI
ce486ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 20, 2024 in 0s

84.93% (-0.57%) compared to 4cec257

View this Pull Request on Codecov

84.93% (-0.57%) compared to 4cec257

Details

Codecov Report

Attention: Patch coverage is 34.50479% with 205 lines in your changes missing coverage. Please review.

Project coverage is 84.93%. Comparing base (4cec257) to head (ce486ae).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 8.08% 91 Missing ⚠️
...s/projects/NIMServiceModal/NIMModelListSection.tsx 1.92% 51 Missing ⚠️
...ving/screens/projects/EmptyNIMModelServingCard.tsx 10.34% 26 Missing ⚠️
...rc/pages/modelServing/screens/projects/nimUtils.ts 51.35% 18 Missing ⚠️
.../NIMServiceModal/NIMModelDeploymentNameSection.tsx 16.66% 5 Missing ⚠️
...d/src/pages/modelServing/screens/projects/utils.ts 85.18% 4 Missing ⚠️
...lServing/screens/projects/ModelServingPlatform.tsx 83.33% 2 Missing ⚠️
...ens/projects/NIMServiceModal/NIMPVCSizeSection.tsx 33.33% 2 Missing ⚠️
...ns/detail/overview/serverModels/AddModelFooter.tsx 75.00% 2 Missing ⚠️
...il/overview/serverModels/PlatformSelectSection.tsx 87.50% 2 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
- Coverage   85.50%   84.93%   -0.57%     
==========================================
  Files        1280     1287       +7     
  Lines       28190    28529     +339     
  Branches     7535     7642     +107     
==========================================
+ Hits        24103    24232     +129     
- Misses       4087     4297     +210
Files with missing lines Coverage Δ
frontend/src/api/k8s/inferenceServices.ts 98.80% <100.00%> (+0.05%) ⬆️
frontend/src/api/k8s/pvcs.ts 100.00% <100.00%> (ø)
frontend/src/concepts/areas/const.ts 100.00% <ø> (ø)
frontend/src/concepts/areas/types.ts 100.00% <100.00%> (ø)
frontend/src/k8sTypes.ts 100.00% <ø> (ø)
...erving/screens/global/InferenceServiceTableRow.tsx 97.14% <ø> (ø)
frontend/src/pages/modelServing/screens/types.ts 100.00% <ø> (ø)
...tend/src/pages/projects/components/PVSizeField.tsx 100.00% <100.00%> (ø)
.../serverModels/deployedModels/DeployedModelCard.tsx 93.33% <100.00%> (+1.02%) ⬆️
frontend/src/pages/projects/types.ts 100.00% <100.00%> (ø)
... and 12 more

... and 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cec257...ce486ae. Read the comment docs.

View more details on Codecov