feat: integrating NIM model UI

[olavtar]

Description

Adding NIM UI changes.

How Has This Been Tested?

Tested locally.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[openshift-ci]

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andrewballantyne]

/ok-to-test

[andrewballantyne]

I've ran out of time to do a review... but one final comment is to look into feature flags; unfortunately this is semi poorly documented. But we have arch docs & a series of flags existing today (initial defaults) -- basically you'll need to ask the forum channel of the Dashboard for help and/or follow one of the existing flags and dupe it for NIM overall.

This should allow you to control things like disabling the metrics link & in general hiding all your UI code (don't worry about the manifests) -- so the API can be available but not the UI (sometimes this is hugely beneficial to our customers).

Also, we do want to get Mocked Cypress Tests into this work asap -- but it doesn't need to be this PR. Have you had a chance to look at the existing ones around KServe?

[andrewballantyne]

Okay, a much more through review... testing this out on clusters not enabled with NIMs to see what happens & I'll test it out on you cluster after that.

[andrewballantyne]

Additional comments we discussed in DM -- putting them in code comment threads for ease of replying.

[andrewballantyne]

Closing in -- let me do some testing and get you that flag to hide the metrics link

[andrewballantyne]

Alright, this is a NIT -- we may need to swing back for this as we are trying to do this today.

Please make this a custom hook so logic is repeatable and reusable.

[andrewballantyne]

FWIW, you should have this down to isNIMAvailable -- avoid unnecessarily unravelled logic whenever possible. Neither of these values have unique purpose on their own.

[andrewballantyne]

There is more to do here -- but this is a good foundation. Approving. We'll follow up with additional PRs next week.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 34.50479% with 205 lines in your changes missing coverage. Please review.

Project coverage is 84.93%. Comparing base (4cec257) to head (ce486ae).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...projects/NIMServiceModal/DeployNIMServiceModal.tsx	8.08%	91 Missing ⚠️
...s/projects/NIMServiceModal/NIMModelListSection.tsx	1.92%	51 Missing ⚠️
...ving/screens/projects/EmptyNIMModelServingCard.tsx	10.34%	26 Missing ⚠️
...rc/pages/modelServing/screens/projects/nimUtils.ts	51.35%	18 Missing ⚠️
.../NIMServiceModal/NIMModelDeploymentNameSection.tsx	16.66%	5 Missing ⚠️
...d/src/pages/modelServing/screens/projects/utils.ts	85.18%	4 Missing ⚠️
...lServing/screens/projects/ModelServingPlatform.tsx	83.33%	2 Missing ⚠️
...ens/projects/NIMServiceModal/NIMPVCSizeSection.tsx	33.33%	2 Missing ⚠️
...ns/detail/overview/serverModels/AddModelFooter.tsx	75.00%	2 Missing ⚠️
...il/overview/serverModels/PlatformSelectSection.tsx	87.50%	2 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
- Coverage   85.50%   84.93%   -0.57%     
==========================================
  Files        1280     1287       +7     
  Lines       28190    28529     +339     
  Branches     7535     7642     +107     
==========================================
+ Hits        24103    24232     +129     
- Misses       4087     4297     +210     

Files with missing lines	Coverage Δ
frontend/src/api/k8s/inferenceServices.ts	98.80% <100.00%> (+0.05%)	⬆️
frontend/src/api/k8s/pvcs.ts	100.00% <100.00%> (ø)
frontend/src/concepts/areas/const.ts	100.00% <ø> (ø)
frontend/src/concepts/areas/types.ts	100.00% <100.00%> (ø)
frontend/src/k8sTypes.ts	100.00% <ø> (ø)
...erving/screens/global/InferenceServiceTableRow.tsx	97.14% <ø> (ø)
frontend/src/pages/modelServing/screens/types.ts	100.00% <ø> (ø)
...tend/src/pages/projects/components/PVSizeField.tsx	100.00% <100.00%> (ø)
.../serverModels/deployedModels/DeployedModelCard.tsx	93.33% <100.00%> (+1.02%)	⬆️
frontend/src/pages/projects/types.ts	100.00% <100.00%> (ø)
... and 12 more

... and 13 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cec257...ce486ae. Read the comment docs.