-
Couldn't load subscription status.
- Fork 653
MIFOSAC-552 Implement Settings Step for New Recurring Deposits Account Flow #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Changes from all commits
2deac2d
050a303
22b3445
51a427c
8b831c7
62df21d
0953fcd
e051c7e
8ca12c0
147202c
99b5975
53076a5
264ced7
504ca32
54cdd17
78a4257
725b701
414d61b
96415ce
dbecf67
3b4fbdd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* | ||
| * Copyright 2025 Mifos Initiative | ||
| * | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
| * | ||
| * See https://github.com/openMF/android-client/blob/master/LICENSE.md | ||
| */ | ||
| package com.mifos.feature.recurringDeposit.di | ||
|
|
||
| import com.mifos.feature.recurringDeposit.newRecurringDepositAccount.RecurringAccountViewModel | ||
| import org.koin.core.module.dsl.viewModelOf | ||
| import org.koin.dsl.module | ||
|
|
||
| val RecurringDepositModule = module { | ||
| viewModelOf(::RecurringAccountViewModel) | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,9 @@ import androidx.navigation.compose.composable | |||||||||||||
| import kotlinx.serialization.Serializable | ||||||||||||||
|
|
||||||||||||||
| @Serializable | ||||||||||||||
| data object RecurringAccountRoute | ||||||||||||||
| data class RecurringAccountRoute( | ||||||||||||||
| val clientId: Int = -1, | ||||||||||||||
| ) | ||||||||||||||
|
Comment on lines
+18
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Validate or remove the default clientId value. The default value of
-data class RecurringAccountRoute(
- val clientId: Int = -1,
-)
+data class RecurringAccountRoute(
+ val clientId: Int,
+)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| fun NavGraphBuilder.recurringAccountDestination() { | ||||||||||||||
| composable<RecurringAccountRoute> { | ||||||||||||||
|
|
@@ -26,8 +28,10 @@ fun NavGraphBuilder.recurringAccountDestination() { | |||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| fun NavController.navigateToRecurringAccountRoute() { | ||||||||||||||
| fun NavController.navigateToRecurringAccountRoute( | ||||||||||||||
| clientId: Int, | ||||||||||||||
| ) { | ||||||||||||||
| this.navigate( | ||||||||||||||
| RecurringAccountRoute, | ||||||||||||||
| RecurringAccountRoute(clientId = clientId), | ||||||||||||||
| ) | ||||||||||||||
| } | ||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Polish copy for clarity and consistency; avoid question-style labels.
Several labels use title-case/questions and have minor grammar issues. Recommend sentence‑case, remove “?” where not interactive questions, and clearer phrasing.
Apply this diff to update only string values (no key renames):
Optional: “frequency” and “type” are very generic keys; consider namespacing (e.g., recurring_frequency_label, recurring_type_label) to avoid collisions across modules.
🤖 Prompt for AI Agents