api-server: Support generic labels #949
Merged
+371
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
aaronchongth
requested changes
May 31, 2024
| ), | ||
| pickup: Optional[str] = Query( | ||
| None, description="comma separated list of pickup names" | ||
| None, description="comma separated list of pickup names", deprecated=True |
There was a problem hiding this comment.
why is this marked as deprecated? Same for the destination query below
There was a problem hiding this comment.
They are being replaced with label=name=value, in main. Let me see if I can port generic label filtering over (already tested sorting doesn't work due to tortoise bug).
There was a problem hiding this comment.
managed to port label sorting over, this also fixes an issue with filtering where if you try to filter by pickup and destination you get no result even though there is a task that meets the criteria.
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
aaronchongth
requested changes
Jun 5, 2024
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
aaronchongth
approved these changes
Jun 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Supports labels without requiring the schema to be strongly defined. This is still a bit hacky, it still assumes the label is a json with a
descriptionfield while labels in RMF are free-form strings. RMF needs to support key value pair labels for us to be able to use them "natively".Another issue is that tortoise-orm is lacking many features which prevent us to implement proper sorting on generic labels so we must still use hacks for the
pickupanddestinationfields. We could use raw sql for this or drop support for sorting by labels.Self-checks
Discussion