Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted use of asyncio.Lock, just catch exceptions instead #944

Merged
merged 1 commit into from
May 8, 2024
Merged

Reverted use of asyncio.Lock, just catch exceptions instead #944

merged 1 commit into from
May 8, 2024

Conversation

aaronchongth
Copy link
Member

What's new

Revert use of mutex and lock for task state saving, catch exception instead.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth aaronchongth merged commit 35a9b0d into deploy/hammer May 8, 2024
2 checks passed
@aaronchongth aaronchongth deleted the hammer/save-state-race-condition branch May 8, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aaronchongth