Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hammer/fire alarm #934

Merged
merged 8 commits into from
May 9, 2024
Merged

Hammer/fire alarm #934

merged 8 commits into from
May 9, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Apr 16, 2024 •
edited
Loading

What's new

  • basic UI for resetting fire alarm trigger, only for admins
  • backend for fire alarm trigger (TODO apply authz in backend too)
    image

image

image

image

Testing

Trigger the fire alarm, before trying the UI to reset it

ros2 topic pub -1 /fire_alarm_trigger std_msgs/Bool '{data: true}'

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth aaronchongth requested a review from koonpeng May 6, 2024 04:26
@aaronchongth
Tests and lint
cd4b4b1 
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth
Updated note
6eb5777 
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth
Use warning for dialog, and added todo to use authz
253ab34 
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth merged commit 5635b1c into deploy/hammer May 9, 2024
4 checks passed
@aaronchongth aaronchongth deleted the hammer/fire-alarm branch May 9, 2024 07:43
@aaronchongth aaronchongth mentioned this pull request Jul 23, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koonpeng koonpeng koonpeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchongth @koonpeng