Port/icons tests change level fix #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Render image if robot icon exists Signed-off-by: angatupyry <[email protected]> * Add scale to robot resource Signed-off-by: angatupyry <[email protected]> * Using scale if exists in resource Signed-off-by: angatupyry <[email protected]> * Make waypoints transparent Signed-off-by: angatupyry <[email protected]> * Adjust text according to its length Signed-off-by: angatupyry <[email protected]> * Remove hasOwn property control Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]> (cherry picked from commit db60f9c) Signed-off-by: Aaron Chong <[email protected]>
* Separate components to make it more testable Signed-off-by: angatupyry <[email protected]> * Create react three components tests Signed-off-by: angatupyry <[email protected]> * Add test for shape three rendering component Signed-off-by: angatupyry <[email protected]> * Create three fiber component test Signed-off-by: angatupyry <[email protected]> * Add test to layers controller Signed-off-by: angatupyry <[email protected]> * Add test id to the component Signed-off-by: angatupyry <[email protected]> * Install test-renderer in order to create test for three. Remove datatest id because it make app break Signed-off-by: angatupyry <[email protected]> * Fix spanish description Signed-off-by: angatupyry <[email protected]> * Change the way to import circle shape component Signed-off-by: angatupyry <[email protected]> * Fixing merge conflict Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]> (cherry picked from commit 3c19fe6) Signed-off-by: Aaron Chong <[email protected]>
* Fix the bug that keeps the robot in the opposite position to its task Signed-off-by: angatupyry <[email protected]> * Delete robot name from state if we can't get the current level Signed-off-by: angatupyry <[email protected]> * Check if robot location is available before attempting to render (#825) Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: angatupyry <[email protected]> Signed-off-by: Aaron Chong <[email protected]> Co-authored-by: Aaron Chong <[email protected]> (cherry picked from commit 6f7da8c) Signed-off-by: Aaron Chong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## deploy/hammer #827 +/- ##
=================================================
+ Coverage 49.30% 49.35% +0.04%
=================================================
Files 284 285 +1
Lines 7462 7564 +102
Branches 1023 1050 +27
=================================================
+ Hits 3679 3733 +54
- Misses 3640 3682 +42
- Partials 143 149 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 574de78) Signed-off-by: Aaron Chong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
useEffectFix recursive call in effect #826Self-checks