Fix/ci (#1051)

* Rebuild minimal-rmf images Signed-off-by: Aaron Chong <[email protected]> * Revert nightly build schedule Signed-off-by: Aaron Chong <[email protected]> * Remove mention of figma, fix dep triggers for workflow Signed-off-by: Aaron Chong <[email protected]> * Fix ros-translator test Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>
open-rmf · Feb 21, 2025 · b66a7a6 · b66a7a6
1 parent b20f320
commit b66a7a6
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 10 deletions.
diff --git a/.github/minimal-rmf/Dockerfile b/.github/minimal-rmf/Dockerfile
@@ -1,7 +1,7 @@
-ARG BASE_IMAGE=docker.io/ros:jazzy-ros-base
+ARG ROS_DISTRO=jazzy
+ARG BASE_IMAGE=docker.io/ros:$ROS_DISTRO-ros-base
 FROM $BASE_IMAGE
 ARG BRANCH=main
-ARG ROS_DISTRO=jazzy
 
 ### build minimal rmf
 

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -1,7 +1,7 @@
 ## What's new
 
 <!-- NOTE: Pull request title should be "<package>: <summary>", if the PR affects multiple
-  packages, use the main package that it affects. If the PR does not target any specific 
+  packages, use the main package that it affects. If the PR does not target any specific
   packages, use general tags like "ci" or "versioning". -->
 
 <!-- uncomment the next line if this PR fixes an issue -->
@@ -23,7 +23,6 @@
 
 ## Self-checks
 
-- [ ] I have prototyped this new feature (if necessary) on Figma 
 - [ ] I'm familiar with and follow this [Typescript guideline](https://basarat.gitbook.io/typescript/styleguide)
 - [ ] I added unit-tests for new components
 - [ ] I tried testing edge cases

diff --git a/.github/workflows/api-client.yml b/.github/workflows/api-client.yml
@@ -3,7 +3,7 @@ on:
   pull_request:
     paths:
       - '.github/workflows/api-client.yml'
-      - '.github/minimal-rmf'
+      - '.github/minimal-rmf/**'
       - 'packages/api-client/**'
   push:
     branches:

diff --git a/.github/workflows/api-server.yml b/.github/workflows/api-server.yml
@@ -3,7 +3,7 @@ on:
   pull_request:
     paths:
       - '.github/workflows/api-server.yml'
-      - '.github/minimal-rmf'
+      - '.github/minimal-rmf/**'
       - 'packages/api-server/**'
   push:
     branches:

diff --git a/.github/workflows/ghpages.yml b/.github/workflows/ghpages.yml
@@ -5,7 +5,7 @@ on:
   push:
     branches: ["main"]
     paths:
-      - '.github/minimal-rmf'
+      - '.github/minimal-rmf/**'
       - "packages/api-server/**"
 
   # Allows you to run this workflow manually from the Actions tab

diff --git a/.github/workflows/rmf-dashboard-framework.yml b/.github/workflows/rmf-dashboard-framework.yml
@@ -3,7 +3,7 @@ on:
   pull_request:
     paths:
       - '.github/workflows/rmf-dashboard-framework.yml'
-      - '.github/minimal-rmf'
+      - '.github/minimal-rmf/**'
       - 'packages/rmf-dashboard-framework/**'
       - 'packages/rmf-models/**'
       - 'packages/api-client/**'

diff --git a/.github/workflows/ros-translator.yml b/.github/workflows/ros-translator.yml
@@ -3,7 +3,7 @@ on:
   pull_request:
     paths:
       - '.github/workflows/ros-translator.yml'
-      - '.github/minimal-rmf'
+      - '.github/minimal-rmf/**'
       - 'packages/ros-translator/**'
   push:
     branches:
@@ -37,4 +37,4 @@ jobs:
         with:
           package: ros-translator
       - name: test
-        run: . /opt/ros/jazzy/setup.bash && pnpm test
+        run: . /opt/ros/${{ matrix.ros_distribution }}/setup.bash && pnpm test