Skip to content

add flagd provider #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

add flagd provider #18

wants to merge 6 commits into from

Conversation

agardnerIT
Copy link
Contributor

Signed-off-by: agardnerit [email protected]

This PR

  • Adds a Python FlagD Provider

Signed-off-by: agardnerit <[email protected]>
Signed-off-by: agardnerit <[email protected]>
Signed-off-by: agardnerit <[email protected]>
Signed-off-by: agardnerit <[email protected]>
Signed-off-by: agardnerit <[email protected]>
Signed-off-by: agardnerit <[email protected]>
@beeme1mr
Copy link
Member

beeme1mr commented Oct 3, 2022

Thanks @agardnerIT! The code looks fine but providers shouldn't be included in the SDK. Other SDKs have a "contrib" repo for providers but one hasn't been created for Python yet. Would you be interested in starting one?

@tcarrio
Copy link
Member

tcarrio commented Oct 29, 2022

Hey @agardnerIT, I applied your commits to the python-sdk-contrib repo and opened a PR. You can find it here.

I think this PR can be closed now 🙂

@ajhelsby ajhelsby closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants