Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flagd provider #3

Merged
merged 16 commits into from
Jul 18, 2023

Conversation

tcarrio
Copy link
Member

@tcarrio tcarrio commented Oct 29, 2022

This PR

This PR was started using commits from python-sdk from @agardnerIT. See the original PR for more info. It has since been refactored to the structure of python-sdk-contrib and into multiple Python modules to further separate concerns. Certain files have been incorporated from python-sdk (mainline and PRs in reviews).

Related Issues

Provides the initial flagd provider.

Notes

Follow-up Tasks

Clean up, linting, masking internal methods, etc.

How to test

Initial unit tests included.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #3 (b3defb0) into main (eadcb28) will increase coverage by 72.00%.
The diff coverage is 72.00%.

@@            Coverage Diff            @@
##           main       #3       +/-   ##
=========================================
+ Coverage      0   72.00%   +72.00%     
=========================================
  Files         0        7        +7     
  Lines         0      100      +100     
=========================================
+ Hits          0       72       +72     
- Misses        0       28       +28     
Flag Coverage Δ
unittests 72.00% <72.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_feature_contrib/providers/flagd/provider.py 60.00% <60.00%> (ø)
...ure_contrib/providers/flagd/web_api_url_factory.py 70.37% <70.37%> (ø)
...b/providers/flagd/evaluation_context_serializer.py 71.42% <71.42%> (ø)
open_feature_contrib/providers/flagd/__init__.py 100.00% <100.00%> (ø)
open_feature_contrib/providers/flagd/defaults.py 100.00% <100.00%> (ø)
open_feature_contrib/providers/flagd/flag_type.py 100.00% <100.00%> (ø)
tests/providers/conftest.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jamescarr
Copy link
Contributor

@tcarrio what else does this PR need to merge? Happy to pitch in and assist!

@tcarrio
Copy link
Member Author

tcarrio commented Jun 30, 2023

@jamescarr I wanted to do a review of the CONTRIBUTING.md file to make sure all references were updated. Outside of that this should be good to merge as the initial alpha of the Flagd provider (utilizing the gRPC Web endpoints of Flagd).

I noticed you've introduced a new Makefile as well in #9. That can likely expand on the one in here, which already targets requirements-dev for local dev setup. Other than that though that one provides a better DX like default help output, so thanks for that 😉

@federicobond
Copy link
Member

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this in concept, but I will differ to @federicobond for the finer details.

Copy link
Member

@federicobond federicobond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good for a first version. We should probably replace it with a gRPC transport version down the road.

agardnerIT and others added 12 commits July 17, 2023 18:24
* add flagd provider

Signed-off-by: agardnerit <[email protected]>

* update vars

Signed-off-by: agardnerit <[email protected]>

* update conftest.py

Signed-off-by: agardnerit <[email protected]>

* directly return

Signed-off-by: agardnerit <[email protected]>

* directly return boolean

Signed-off-by: agardnerit <[email protected]>

* remove prints

Signed-off-by: agardnerit <[email protected]>
@beeme1mr beeme1mr merged commit 1c52d12 into open-feature:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants