-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flagd provider #3
Conversation
44911ad
to
7ecdfa4
Compare
90a9846
to
edf6ba1
Compare
bcf318f
to
f71e8d5
Compare
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
=========================================
+ Coverage 0 72.00% +72.00%
=========================================
Files 0 7 +7
Lines 0 100 +100
=========================================
+ Hits 0 72 +72
- Misses 0 28 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@tcarrio what else does this PR need to merge? Happy to pitch in and assist! |
@jamescarr I wanted to do a review of the CONTRIBUTING.md file to make sure all references were updated. Outside of that this should be good to merge as the initial alpha of the Flagd provider (utilizing the gRPC Web endpoints of Flagd). I noticed you've introduced a new Makefile as well in #9. That can likely expand on the one in here, which already targets |
open_feature_contrib/providers/flagd/evaluation_context_serializer.py
Outdated
Show resolved
Hide resolved
3ec465c
to
45b8214
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this in concept, but I will differ to @federicobond for the finer details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good for a first version. We should probably replace it with a gRPC transport version down the road.
* add flagd provider Signed-off-by: agardnerit <[email protected]> * update vars Signed-off-by: agardnerit <[email protected]> * update conftest.py Signed-off-by: agardnerit <[email protected]> * directly return Signed-off-by: agardnerit <[email protected]> * directly return boolean Signed-off-by: agardnerit <[email protected]> * remove prints Signed-off-by: agardnerit <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
…, ignore venv Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
…tion of factory method Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Tom Carrio <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
44ed53d
to
b3defb0
Compare
This PR
This PR was started using commits from
python-sdk
from @agardnerIT. See the original PR for more info. It has since been refactored to the structure ofpython-sdk-contrib
and into multiple Python modules to further separate concerns. Certain files have been incorporated frompython-sdk
(mainline and PRs in reviews).Related Issues
Provides the initial flagd provider.
Notes
Follow-up Tasks
Clean up, linting, masking internal methods, etc.
How to test
Initial unit tests included.