Validate proposal against schema in submission endpoint#604
Open
valentin0h wants to merge 11 commits intodevfrom
Open
Validate proposal against schema in submission endpoint#604valentin0h wants to merge 11 commits intodevfrom
valentin0h wants to merge 11 commits intodevfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
submitProposal now fetches field values from the TipTap collaboration document instead of validating against the cached proposalData DB column. This fixes validation rejecting proposals with custom template fields that only exist in the Yjs doc. - assembleProposalData: maps fragment text to the shape AJV expects - getProposalFragmentNames: returns all template fields, not just text - submitProposal: fetches fragments when collaborationDocId exists, falls back to proposalData for legacy proposals - Tests seed fragments via mockCollab.setDocFragments()
- Add XFormat, ProposalPropertySchema, ProposalTemplateSchema to shared types - Remove duplicate type definitions from frontend compileProposalSchema - Remove unsafe casts in assembleProposalData and submitProposal - Widen resolveProposalTemplate param to accept DecisionInstanceData directly
…emplate to ProposalTemplateSchema Replace manual JSON.parse + money field handling with normalizeBudget, refactor if/else chain to switch/case, and propagate ProposalTemplateSchema through resolveProposalTemplate and its callers to eliminate type casts.
valentin0h
force-pushed
the
validate-proposal--against-schema
branch
from
0ca8771 to
3623d5d
Compare
valentin0h
force-pushed
the
validate-proposal--against-schema
branch
from
3623d5d to
3464ca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate proposal data against the template schema when submitting, including fields stored in TipTap collaboration documents. Assembles field values from Yjs document fragments and validates them server-side on submission
Frontend validations will be handled separately.