Validate proposal data on update endpoint#611
Open
valentin0h wants to merge 1 commit intovalidate-proposal--against-schemafrom
Open
Validate proposal data on update endpoint#611valentin0h wants to merge 1 commit intovalidate-proposal--against-schemafrom
valentin0h wants to merge 1 commit intovalidate-proposal--against-schemafrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
valentin0h
force-pushed
the
validate-proposal-on-update
branch
from
0ca8771 to
e172b0a
Compare
valentin0h
force-pushed
the
validate-proposal--against-schema
branch
from
3623d5d to
3464ca5
Compare
valentin0h
force-pushed
the
validate-proposal--against-schema
branch
from
3464ca5 to
438f085
Compare
Extract validateProposalAgainstTemplate to DRY up the collab-doc-aware validation logic shared by submitProposal and updateProposal. The update endpoint now uses resolveProposalTemplate (checking both instanceData and processSchema) instead of only reading processSchema directly.
valentin0h
force-pushed
the
validate-proposal-on-update
branch
from
e172b0a to
7e9c12e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #604, now updating the update proposal handler to validate against the schema.