EventStream Puzzler #75
Conversation
src/index.ts
Outdated
|
|
||
| export function scoreEventStream(eventStream: ReadonlyArray<event>): highest_score { | ||
| return { | ||
| events: [], |
There was a problem hiding this comment.
I added a return object here because otherwise my test suite would not run and I have typed the output for the function
src/index.test.ts
Outdated
| it('should return an object with an events property', () => { | ||
| const actual = scoreEventStream(eventStream); | ||
|
|
||
| expect(actual).toHaveProperty("events"); | ||
| }) | ||
|
|
||
| it('should return an object with a score property', () => { | ||
| const actual = scoreEventStream(eventStream); | ||
|
|
||
| expect(actual).toHaveProperty("score"); | ||
| }) |
There was a problem hiding this comment.
these two tests can be combined, since you're testing that the return object has the expected properties.
just do both expects in the same test.
src/index.test.ts
Outdated
| expect(actual).toHaveProperty("score"); | ||
| }) | ||
|
|
||
| it('successfully assess the length of the inputted array', () => { |
There was a problem hiding this comment.
future tests should include checks for different region lengths? If not, just add a comment here saying that the default length is 5.
src/index.ts
Outdated
| @@ -1 +1,16 @@ | |||
| //Define class/functions here | |||
| type event = { | |||
src/index.ts
Outdated
| eventType: string | ||
| } | ||
|
|
||
| type highest_score = { |
| expect(actual).toHaveProperty("score"); | ||
| }) | ||
|
|
||
| it('length of events array in return object should be no greater than 5', () => { |
There was a problem hiding this comment.
since the function now accepts the regionLength argument, then we need additional tests to verify expected array lengths. Default vs > vs <
| @@ -0,0 +1,13 @@ | |||
| export interface event { | |||
There was a problem hiding this comment.
| export interface event { | |
| export interface Event { |
There was a problem hiding this comment.
interfaces and types should be capialized.
There was a problem hiding this comment.
type EventStream = ReadonlyArray<Event>;
| return eventStreamWithScores.map(e => { return e.score }) | ||
| } | ||
|
|
||
| export function scoreEventStream(eventStream: ReadonlyArray<event>, subRegionLength: number = 5) { |
What this is
Red phase tests for eventStream puzzler
Ticket
Sarah-EventStream-Puzzler
Steps to Verify
run
yarn testin terminalMedia
