Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emma tdd lesson1 pass tests #52

Open
wants to merge 18 commits into
base: emma-tdd-workshop
Choose a base branch
from

Conversation

emmalgs
Copy link

@emmalgs emmalgs commented Aug 16, 2023

What This Is

Green Phase for Lesson 1 Testing

  • All tests passing for Lesson 1

Ticket

n/a

Steps To Verify

  • In the project directory on branch 'emma-tdd-lesson1-pass-tests' run yarn test

Media

Passing tests in terminal
Screenshot 2023-08-16 at 1 33 54 PM

Notes

This PR relies on Emma Lesson1 Red Phase

@DuHerb DuHerb marked this pull request as draft August 16, 2023 23:12
@DuHerb DuHerb changed the base branch from emma-tdd-workshop to emma-tdd-lesson1-fail-tests August 16, 2023 23:12
@emmalgs emmalgs changed the base branch from emma-tdd-lesson1-fail-tests to emma-tdd-workshop August 16, 2023 23:43
@DuHerb
Copy link

DuHerb commented Aug 17, 2023

PR note:
The Relies On section isn't one that we'd ever include in a PR. I would add this type of information to Additional Context / Notes section.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@emmalgs emmalgs marked this pull request as ready for review August 21, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants