Daniel user api #41
Draft
Daniel user api #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen array is invalid
…ad of direct functions
DuHerb
commented
Jun 14, 2022
| name: string | ||
| favoriteColor: string | ||
| age: number |
There was a problem hiding this comment.
all properties here should be readonly
| export class UserAPI { | ||
|
|
||
| constructor(private _users: Record<string, IUser> = {}) { |
There was a problem hiding this comment.
an exported Users type would be beneficial here, since it is a domain shape that is used in many places. export type Users = Record<string, IUser>
| } | ||
|
|
||
| getUserById(id: string): Readonly<IUser> { |
There was a problem hiding this comment.
Suggested change
| getUserById(id: string): Readonly<IUser> { | |
| getUserById(id: string): IUser { |
because IUser is readonly (or will be once all of its properties are readonly), we don't need Readonly here.
there is a pattern you might see in some places where a declared interface extends an empty Readonly object, so that the properties don't have to be individually declared as readonly. That pattern would also be acceptable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
For review only.