Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create CRUD functions for UserAPI class #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lauriewaller
Copy link

@rachoac here is code for your review. Thanks!


updateUser = (user) => {
this.users = { ...this.users, [user.id]: user };
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachoac is this correct to use the computed property here to update by id?

deleteUser = (id) => {
const { [id]: user, ...updatedUsers } = this.users;
this.users = updatedUsers;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachoac what would be correct to return for this function? I should have made a clear note on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant