TS data verification #39
Conversation
…erByFavoriteColor.
"merge updates to class into testing branch before PR is complete"
…-starter-lab into testing-branch
…-starter-lab into object-convert
| @@ -0,0 +1,29 @@ | |||
| { | |||
There was a problem hiding this comment.
this launch.json file should be listed in your .gitignore file
There was a problem hiding this comment.
Done, I don't think I understand git versioning well enough to scrub the file from the git repo history. I did it once on a personal project, but scrubbed the entire repo. I'm afraid I'll screw something up if I try it here.
I did add the /vscode folder the gitignore though.
src/index.ts
Outdated
| name: string | ||
| favColor: string | ||
| age: number |
src/index.ts
Outdated
| private _users: Readonly<Record<string, IUser>> | ||
|
|
||
| constructor(seedData: Record<string, IUser> = {}) { |
There was a problem hiding this comment.
Wouldn't be a bad thing to define/export an IUsers type. type IUser = Record<string, IUser>
only suggested here because we use this list as a type in several places.
src/index.ts
Outdated
| } | ||
|
|
||
| addUser(user: IUser): IUser{ |
There was a problem hiding this comment.
| addUser(user: IUser): IUser{ | |
| addUser(user: IUser): IUser { |
space ^^
There was a problem hiding this comment.
looks like space is missing after return types on several methods. should fix
src/index.ts
Outdated
| } | ||
|
|
||
| searchUserByName(name: string): Array<IUser>{ |
src/index.ts
Outdated
| } | ||
|
|
||
| searchUsersByFavoriteColor(color: string): Array<IUser>{ |
Ticket:
What this Does:
Media:
None
Testing